Merge pull request mozilla-services#4288 from willkg/1416841-drop-dot…

…star

fixes bug 1416841 - nix .* at end of lines in siglist files

socorro/siglists/README.rst

@@ -30,7 +30,19 @@ When generating a C signature, 5 steps are involved.
    associated code line number added to them, like this: ``signature:42``.
 
 The generated signature is a concatenation of all the accumulated signatures,
-separated with a pipe sign (``|``).
+separated with a pipe sign (``|``), and converted to a regular expression.
+
+Signature generation then uses ``.match()`` to match frames.
+
+Because of that, when changing these lists, make sure you keep the following
+things in mind:
+
+1. Make sure you're using valid regular expression syntax and escape special
+   characters like ``(``, ``)``, ``.``, and ``$``.
+2. There's no need to add a trailing ``.*`` since signature generation uses
+   ``.match()`` which will match from the beginning of the string.
+3. Try to keep it roughly in alphabetical order so as to make it easier to skim
+   through later.
 
 
 Signature Sentinels

socorro/siglists/irrelevant_signature_re.txt

@@ -2,57 +2,59 @@
 #
 # Regular expressions matching frame signatures that should be ignored when
 # generating an overall signature.
+#
+# Read the README.rst for instructions and tips on editing this file.
 
 @0x[0-9a-fA-F]{2,}
 @0x[1-9a-fA-F]
-__aeabi_fcmpgt.*
+__aeabi_fcmpgt
 ashmem
 __assert_rtn
-app_process@0x.*
-AppleIntelHD3000GraphicsGLDriver@.*
-core\.odex@0x.*
-core::panicking::.*
+app_process@0x
+AppleIntelHD3000GraphicsGLDriver@
+core\.odex@0x
+core::panicking::
 CrashStatsLogForwarder::CrashAction
 _CxxThrowException
 dalvik-heap
 dalvik-jit-code-cache
 dalvik-LinearAlloc
 dalvik-mark-stack
-data@app@org\.mozilla\.f.*-\d\.apk@classes\.dex@0x.*
+data@app@org\.mozilla\.f.*-\d\.apk@classes\.dex@0x
 .*FNODOBFM
-framework\.odex@0x.*
+framework\.odex@0x
 GetLCIDFromLangListNodeWithLICCheck
 gfxPlatform::GetPlatform
 google_breakpad::CrashGenerationClient::RequestDumpForException
 google_breakpad::ExceptionHandler::SignalHandler
 google_breakpad::ExceptionHandler::WriteMinidumpWithException
 google_breakpad::ReceivePort::WaitForMessage
 KiFastSystemCallRet
-libandroid_runtime\.so@0x.*
-libbinder\.so@0x.*
-libc\.so@.*
-libc-2\.5\.so@.*
-libEGL\.so@.*
-libdvm\.so\s*@\s*0x.*
-libgui\.so@0x.*
-libicudata.so@.*
-libMali\.so@0x.*
-libutils\.so@0x.*
-libz\.so@0x.*
-linux-gate\.so@0x.*
+libandroid_runtime\.so@0x
+libbinder\.so@0x
+libc\.so@
+libc-2\.5\.so@
+libEGL\.so@
+libdvm\.so\s*@\s*0x
+libgui\.so@0x
+libicudata.so@
+libMali\.so@0x
+libutils\.so@0x
+libz\.so@0x
+linux-gate\.so@0x
 mach_msg
 _mach_msg
 mach_msg_trap
 _mach_msg_trap
-mnt@asec@org\.mozilla\.f.*-\d@pkg\.apk@classes\.dex@0x.*
+mnt@asec@org\.mozilla\.f.*-\d@pkg\.apk@classes\.dex@0x
 MOZ_Assert
 MOZ_Crash
-mozcrt19.dll@0x.*
+mozcrt19.dll@0x
 mozilla::CondVar::Wait
-mozilla::detail::ConditionVariableImpl.*
-mozilla::gfx::Log<.*
+mozilla::detail::ConditionVariableImpl
+mozilla::gfx::Log<
 mozilla::ipc::RPCChannel::Call
-mozilla::ThreadEventQueue.*
+mozilla::ThreadEventQueue
 nsEventQueue::GetEvent
 _NSRaiseError
 nsThread::GetEvent
@@ -64,11 +66,11 @@ NS_ProcessNextEvent
 (Nt|Zw)?WaitForSingleObject(Ex)?
 (Nt|Zw)?WaitForMultipleObjects(Ex)?
 NtWaitForAlertByThreadId
-nvmap@0x.*
-org\.mozilla\.f.*-\d\.apk@0x.*
+nvmap@0x
+org\.mozilla\.f.*-\d\.apk@0x
 PR_WaitCondVar
 RaiseException
-rtc::FatalMessage.*
+rtc::FatalMessage
 RtlpAdjustHeapLookasideDepth
 RtlSleepConditionVariableCS
 RtlSleepConditionVariableSRW
@@ -77,11 +79,11 @@ __sigtramp
 SleepConditionVariableCS
 SleepConditionVariableSRW
 std::_Atomic_fetch_add_4
-std::panicking::.*
-system@framework@.*\.jar@classes\.dex@0x.*
+std::panicking::
+system@framework@.*\.jar@classes\.dex@0x
 ___TERMINATING_DUE_TO_UNCAUGHT_EXCEPTION___
 WaitForSingleObjectExImplementation
 WaitForMultipleObjectsExImplementation
-RealMsgWaitFor.*
+RealMsgWaitFor
 _ZdlPv
 zero