Fix negative validation for pagination

jwdeitch · Aug 17, 2015 · fabee3e · fabee3e
1 parent 1a30db0
commit fabee3e
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/Eloquent/Builder.php b/Eloquent/Builder.php
@@ -3,6 +3,7 @@
 namespace Illuminate\Database\Eloquent;
 
 use Closure;
+use InvalidArgumentException;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Str;
 use Illuminate\Pagination\Paginator;
@@ -265,9 +266,15 @@ public function lists($column, $key = null)
      * @param  string  $pageName
      * @param  int|null  $page
      * @return \Illuminate\Contracts\Pagination\LengthAwarePaginator
+     *
+     * @throws InvalidArgumentException
      */
     public function paginate($perPage = null, $columns = ['*'], $pageName = 'page', $page = null)
     {
+        if( $perPage <= 0) {
+            throw new InvalidArgumentException("Negative values can't be used to query results");
+        }
+
         $total = $this->query->getCountForPagination();
 
         $this->query->forPage(
@@ -291,6 +298,8 @@ public function paginate($perPage = null, $columns = ['*'], $pageName = 'page',
      */
     public function simplePaginate($perPage = null, $columns = ['*'], $pageName = 'page')
     {
+
+
         $page = Paginator::resolveCurrentPage($pageName);
 
         $perPage = $perPage ?: $this->model->getPerPage();