Revert "Add iOS platform view mutation XCUITests to the scenario app (f…

…lutter#11652)" (flutter#12292)

This reverts commit b73cfda.

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

@@ -252,8 +252,7 @@
   }
   // If there were not enough existing clip views, add more.
   while (clipIndex < number_of_clips) {
-    ChildClippingView* clippingView =
-        [[ChildClippingView alloc] initWithFrame:flutter_view_.get().bounds];
+    ChildClippingView* clippingView = [ChildClippingView new];
     [clippingView addSubview:head];
     head = clippingView;
     clipIndex++;

testing/scenario_app/ios/Scenarios/Scenarios.xcodeproj/project.pbxproj

@@ -30,14 +30,6 @@
 		24D47D1B230C79840069DD5E /* golden_platform_view_D211AP.png in Resources */ = {isa = PBXBuildFile; fileRef = 24D47D1A230C79840069DD5E /* golden_platform_view_D211AP.png */; };
 		24D47D1D230CA2700069DD5E /* golden_platform_view_iPhone SE_simulator.png in Resources */ = {isa = PBXBuildFile; fileRef = 24D47D1C230CA2700069DD5E /* golden_platform_view_iPhone SE_simulator.png */; };
 		24F1FB89230B4579005ACE7C /* TextPlatformView.m in Sources */ = {isa = PBXBuildFile; fileRef = 24F1FB87230B4579005ACE7C /* TextPlatformView.m */; };
-		6816DB9E231750ED00A51400 /* GoldenPlatformViewTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 6816DB9D231750ED00A51400 /* GoldenPlatformViewTests.m */; };
-		6816DBA12317573300A51400 /* GoldenImage.m in Sources */ = {isa = PBXBuildFile; fileRef = 6816DBA02317573300A51400 /* GoldenImage.m */; };
-		6816DBA42318358200A51400 /* PlatformViewGoldenTestManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 6816DBA32318358200A51400 /* PlatformViewGoldenTestManager.m */; };
-		6816DBAA2318696600A51400 /* golden_platform_view_clippath_iPhone SE_simulator.png in Resources */ = {isa = PBXBuildFile; fileRef = 6816DBA52318696600A51400 /* golden_platform_view_clippath_iPhone SE_simulator.png */; };
-		6816DBAB2318696600A51400 /* golden_platform_view_transform_iPhone SE_simulator.png in Resources */ = {isa = PBXBuildFile; fileRef = 6816DBA62318696600A51400 /* golden_platform_view_transform_iPhone SE_simulator.png */; };
-		6816DBAC2318696600A51400 /* golden_platform_view_opacity_iPhone SE_simulator.png in Resources */ = {isa = PBXBuildFile; fileRef = 6816DBA72318696600A51400 /* golden_platform_view_opacity_iPhone SE_simulator.png */; };
-		6816DBAD2318696600A51400 /* golden_platform_view_cliprect_iPhone SE_simulator.png in Resources */ = {isa = PBXBuildFile; fileRef = 6816DBA82318696600A51400 /* golden_platform_view_cliprect_iPhone SE_simulator.png */; };
-		6816DBAE2318696600A51400 /* golden_platform_view_cliprrect_iPhone SE_simulator.png in Resources */ = {isa = PBXBuildFile; fileRef = 6816DBA92318696600A51400 /* golden_platform_view_cliprrect_iPhone SE_simulator.png */; };
 /* End PBXBuildFile section */
 
 /* Begin PBXContainerItemProxy section */
@@ -121,17 +113,6 @@
 		24D47D1E230CA4480069DD5E /* README.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = README.md; sourceTree = "<group>"; };
 		24F1FB87230B4579005ACE7C /* TextPlatformView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TextPlatformView.m; sourceTree = "<group>"; };
 		24F1FB88230B4579005ACE7C /* TextPlatformView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextPlatformView.h; sourceTree = "<group>"; };
-		6816DB9C231750ED00A51400 /* GoldenPlatformViewTests.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GoldenPlatformViewTests.h; sourceTree = "<group>"; };
-		6816DB9D231750ED00A51400 /* GoldenPlatformViewTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = GoldenPlatformViewTests.m; sourceTree = "<group>"; };
-		6816DB9F2317573300A51400 /* GoldenImage.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GoldenImage.h; sourceTree = "<group>"; };
-		6816DBA02317573300A51400 /* GoldenImage.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = GoldenImage.m; sourceTree = "<group>"; };
-		6816DBA22318358200A51400 /* PlatformViewGoldenTestManager.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = PlatformViewGoldenTestManager.h; sourceTree = "<group>"; };
-		6816DBA32318358200A51400 /* PlatformViewGoldenTestManager.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = PlatformViewGoldenTestManager.m; sourceTree = "<group>"; };
-		6816DBA52318696600A51400 /* golden_platform_view_clippath_iPhone SE_simulator.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "golden_platform_view_clippath_iPhone SE_simulator.png"; sourceTree = "<group>"; };
-		6816DBA62318696600A51400 /* golden_platform_view_transform_iPhone SE_simulator.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "golden_platform_view_transform_iPhone SE_simulator.png"; sourceTree = "<group>"; };
-		6816DBA72318696600A51400 /* golden_platform_view_opacity_iPhone SE_simulator.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "golden_platform_view_opacity_iPhone SE_simulator.png"; sourceTree = "<group>"; };
-		6816DBA82318696600A51400 /* golden_platform_view_cliprect_iPhone SE_simulator.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "golden_platform_view_cliprect_iPhone SE_simulator.png"; sourceTree = "<group>"; };
-		6816DBA92318696600A51400 /* golden_platform_view_cliprrect_iPhone SE_simulator.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "golden_platform_view_cliprrect_iPhone SE_simulator.png"; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */
@@ -219,20 +200,9 @@
 				244EA6CF230DBE8900B2D26E /* golden_platform_view_D21AP.png */,
 				24D47D1C230CA2700069DD5E /* golden_platform_view_iPhone SE_simulator.png */,
 				24D47D1A230C79840069DD5E /* golden_platform_view_D211AP.png */,
-				6816DBA52318696600A51400 /* golden_platform_view_clippath_iPhone SE_simulator.png */,
-				6816DBA82318696600A51400 /* golden_platform_view_cliprect_iPhone SE_simulator.png */,
-				6816DBA92318696600A51400 /* golden_platform_view_cliprrect_iPhone SE_simulator.png */,
-				6816DBA72318696600A51400 /* golden_platform_view_opacity_iPhone SE_simulator.png */,
-				6816DBA62318696600A51400 /* golden_platform_view_transform_iPhone SE_simulator.png */,
 				248D76EE22E388380012F0C1 /* PlatformViewUITests.m */,
 				248D76F022E388380012F0C1 /* Info.plist */,
 				24D47D1E230CA4480069DD5E /* README.md */,
-				6816DB9C231750ED00A51400 /* GoldenPlatformViewTests.h */,
-				6816DB9D231750ED00A51400 /* GoldenPlatformViewTests.m */,
-				6816DB9F2317573300A51400 /* GoldenImage.h */,
-				6816DBA02317573300A51400 /* GoldenImage.m */,
-				6816DBA22318358200A51400 /* PlatformViewGoldenTestManager.h */,
-				6816DBA32318358200A51400 /* PlatformViewGoldenTestManager.m */,
 			);
 			path = ScenariosUITests;
 			sourceTree = "<group>";
@@ -370,14 +340,9 @@
 			isa = PBXResourcesBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
-				6816DBAE2318696600A51400 /* golden_platform_view_cliprrect_iPhone SE_simulator.png in Resources */,
-				6816DBAB2318696600A51400 /* golden_platform_view_transform_iPhone SE_simulator.png in Resources */,
-				6816DBAA2318696600A51400 /* golden_platform_view_clippath_iPhone SE_simulator.png in Resources */,
-				6816DBAD2318696600A51400 /* golden_platform_view_cliprect_iPhone SE_simulator.png in Resources */,
 				24D47D1B230C79840069DD5E /* golden_platform_view_D211AP.png in Resources */,
 				24D47D1D230CA2700069DD5E /* golden_platform_view_iPhone SE_simulator.png in Resources */,
 				244EA6D0230DBE8900B2D26E /* golden_platform_view_D21AP.png in Resources */,
-				6816DBAC2318696600A51400 /* golden_platform_view_opacity_iPhone SE_simulator.png in Resources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -410,9 +375,6 @@
 			isa = PBXSourcesBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
-				6816DBA12317573300A51400 /* GoldenImage.m in Sources */,
-				6816DB9E231750ED00A51400 /* GoldenPlatformViewTests.m in Sources */,
-				6816DBA42318358200A51400 /* PlatformViewGoldenTestManager.m in Sources */,
 				248D76EF22E388380012F0C1 /* PlatformViewUITests.m in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;

testing/scenario_app/ios/Scenarios/Scenarios/AppDelegate.m

@@ -25,55 +25,27 @@ - (BOOL)application:(UIApplication*)application
 
   // This argument is used by the XCUITest for Platform Views so that the app
   // under test will create platform views.
-  // The launchArgsMap should match the one in the `PlatformVieGoldenTestManager`.
-  NSDictionary<NSString*, NSString*>* launchArgsMap = @{
-    @"--platform-view" : @"platform_view",
-    @"--platform-view-cliprect" : @"platform_view_cliprect",
-    @"--platform-view-cliprrect" : @"platform_view_cliprrect",
-    @"--platform-view-clippath" : @"platform_view_clippath",
-    @"--platform-view-transform" : @"platform_view_transform",
-    @"--platform-view-opacity" : @"platform_view_opacity",
-  };
-  __block NSString* goldenTestName = nil;
-  [launchArgsMap
-      enumerateKeysAndObjectsUsingBlock:^(NSString* argument, NSString* testName, BOOL* stop) {
-        if ([[[NSProcessInfo processInfo] arguments] containsObject:argument]) {
-          goldenTestName = testName;
-          *stop = YES;
-        }
-      }];
-
-  if (goldenTestName) {
-    [self readyContextForPlatformViewTests:goldenTestName];
+  if ([[[NSProcessInfo processInfo] arguments] containsObject:@"--platform-view"]) {
+    FlutterEngine* engine = [[FlutterEngine alloc] initWithScenario:@"text_platform_view"
+                                                     withCompletion:nil];
+    [engine runWithEntrypoint:nil];
+
+    FlutterViewController* flutterViewController =
+        [[NoStatusBarFlutterViewController alloc] initWithEngine:engine nibName:nil bundle:nil];
+    TextPlatformViewFactory* textPlatformViewFactory =
+        [[TextPlatformViewFactory alloc] initWithMessenger:flutterViewController.binaryMessenger];
+    NSObject<FlutterPluginRegistrar>* registrar =
+        [flutterViewController.engine registrarForPlugin:@"scenarios/TextPlatformViewPlugin"];
+    [registrar registerViewFactory:textPlatformViewFactory withId:@"scenarios/textPlatformView"];
+    self.window.rootViewController = flutterViewController;
   } else if ([[[NSProcessInfo processInfo] arguments] containsObject:@"--screen-before-flutter"]) {
     self.window.rootViewController = [[ScreenBeforeFlutter alloc] initWithEngineRunCompletion:nil];
   } else {
     self.window.rootViewController = [[UIViewController alloc] init];
   }
-
   [self.window makeKeyAndVisible];
-  return [super application:application didFinishLaunchingWithOptions:launchOptions];
-}
-
-- (void)readyContextForPlatformViewTests:(NSString*)scenarioIdentifier {
-  FlutterEngine* engine = [[FlutterEngine alloc] initWithName:@"PlatformViewTest" project:nil];
-  [engine runWithEntrypoint:nil];
 
-  FlutterViewController* flutterViewController =
-      [[NoStatusBarFlutterViewController alloc] initWithEngine:engine nibName:nil bundle:nil];
-  [engine.binaryMessenger
-      setMessageHandlerOnChannel:@"scenario_status"
-            binaryMessageHandler:^(NSData* _Nullable message, FlutterBinaryReply _Nonnull reply) {
-              [engine.binaryMessenger
-                  sendOnChannel:@"set_scenario"
-                        message:[scenarioIdentifier dataUsingEncoding:NSUTF8StringEncoding]];
-            }];
-  TextPlatformViewFactory* textPlatformViewFactory =
-      [[TextPlatformViewFactory alloc] initWithMessenger:flutterViewController.binaryMessenger];
-  NSObject<FlutterPluginRegistrar>* registrar =
-      [flutterViewController.engine registrarForPlugin:@"scenarios/TextPlatformViewPlugin"];
-  [registrar registerViewFactory:textPlatformViewFactory withId:@"scenarios/textPlatformView"];
-  self.window.rootViewController = flutterViewController;
+  return [super application:application didFinishLaunchingWithOptions:launchOptions];
 }
 
 @end