Enable lazy-async-stacks by-default in all modes (flutter#16556)

This was already enabled by-default in AOT mode in [0] - which made the gen_snapshot invocations use "--lazy-async-stacks --no-causal-async-stacks". See go/dart-10x-faster-async for more information. [0] flutter/flutter@347823234fd
jwise · Feb 20, 2020 · fdabcad · fdabcad
1 parent 6b3d439
commit fdabcad
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 18 deletions.
diff --git a/runtime/dart_vm.cc b/runtime/dart_vm.cc
@@ -60,7 +60,8 @@ static const char* kDartLanguageArgs[] = {
     // clang-format off
     "--enable_mirrors=false",
     "--background_compilation",
-    "--causal_async_stacks",
+    "--no-causal_async_stacks",
+    "--lazy_async_stacks",
     // clang-format on
 };
 

diff --git a/shell/common/shell_unittests.cc b/shell/common/shell_unittests.cc
@@ -281,16 +281,20 @@ TEST_F(ShellTest, BlacklistedDartVMFlag) {
 TEST_F(ShellTest, WhitelistedDartVMFlag) {
   const std::vector<fml::CommandLine::Option> options = {
       fml::CommandLine::Option("dart-flags",
+                               "--lazy_async_stacks,--no-causal_async_stacks,"
                                "--max_profile_depth 1,--random_seed 42")};
   fml::CommandLine command_line("", options, std::vector<std::string>());
   flutter::Settings settings = flutter::SettingsFromCommandLine(command_line);
 
+  EXPECT_GE(settings.dart_flags.size(), 2u);
+  EXPECT_EQ(settings.dart_flags[0], "--lazy_async_stacks");
+  EXPECT_EQ(settings.dart_flags[1], "--no-causal_async_stacks");
 #if !FLUTTER_RELEASE
-  EXPECT_EQ(settings.dart_flags.size(), 2u);
-  EXPECT_EQ(settings.dart_flags[0], "--max_profile_depth 1");
-  EXPECT_EQ(settings.dart_flags[1], "--random_seed 42");
+  EXPECT_EQ(settings.dart_flags.size(), 4u);
+  EXPECT_EQ(settings.dart_flags[2], "--max_profile_depth 1");
+  EXPECT_EQ(settings.dart_flags[3], "--random_seed 42");
 #else
-  EXPECT_EQ(settings.dart_flags.size(), 0u);
+  EXPECT_EQ(settings.dart_flags.size(), 2u);
 #endif
 }
 

diff --git a/shell/common/switches.cc b/shell/common/switches.cc
@@ -41,8 +41,8 @@ struct SwitchDesc {
 
 // clang-format off
 static const std::string gDartFlagsWhitelist[] = {
-    "--no-causal_async_stacks",
     "--lazy_async_stacks",
+    "--no-causal_async_stacks",
 };
 // clang-format on
 

diff --git a/shell/platform/fuchsia/dart_runner/dart_runner.cc b/shell/platform/fuchsia/dart_runner/dart_runner.cc
@@ -35,8 +35,7 @@ namespace {
 
 const char* kDartVMArgs[] = {
     // clang-format off
-    // TODO(FL-117): Re-enable causal async stack traces when this issue is
-    // addressed.
+    "--lazy_async_stacks",
     "--no_causal_async_stacks",
 
 #if !defined(FLUTTER_PROFILE)

diff --git a/shell/platform/fuchsia/dart_runner/embedder/BUILD.gn b/shell/platform/fuchsia/dart_runner/embedder/BUILD.gn
@@ -53,6 +53,7 @@ template("create_aot_snapshot") {
 
     args = [
       "--no_causal_async_stacks",
+      "--lazy_async_stacks",
       "--deterministic",
       "--snapshot_kind=vm-aot-assembly",
       "--assembly=" + rebase_path(snapshot_assembly),

diff --git a/shell/platform/fuchsia/dart_runner/kernel/BUILD.gn b/shell/platform/fuchsia/dart_runner/kernel/BUILD.gn
@@ -71,9 +71,8 @@ template("create_kernel_core_snapshot") {
     tool = gen_snapshot_to_use
 
     args = [
-      # TODO(FL-117): Re-enable causal async stack traces when this issue is
-      # addressed.
       "--no_causal_async_stacks",
+      "--lazy_async_stacks",
       "--use_bytecode_compiler",
       "--enable_mirrors=false",
       "--deterministic",

diff --git a/shell/platform/fuchsia/dart_runner/vmservice/BUILD.gn b/shell/platform/fuchsia/dart_runner/vmservice/BUILD.gn
@@ -64,6 +64,7 @@ template("aot_snapshot") {
 
     args = [
       "--no_causal_async_stacks",
+      "--lazy_async_stacks",
       "--deterministic",
       "--snapshot_kind=app-aot-elf",
       "--elf=" + rebase_path(snapshot_path),

diff --git a/shell/platform/fuchsia/flutter/component.cc b/shell/platform/fuchsia/flutter/component.cc
@@ -353,10 +353,6 @@ Application::Application(
   settings_.task_observer_remove = std::bind(
       &CurrentMessageLoopRemoveAfterTaskObserver, std::placeholders::_1);
 
-  // TODO(FL-117): Re-enable causal async stack traces when this issue is
-  // addressed.
-  settings_.dart_flags = {"--no_causal_async_stacks"};
-
   // Disable code collection as it interferes with JIT code warmup
   // by decreasing usage counters and flushing code which is still useful.
   settings_.dart_flags.push_back("--no-collect_code");

diff --git a/shell/platform/fuchsia/flutter/kernel/BUILD.gn b/shell/platform/fuchsia/flutter/kernel/BUILD.gn
@@ -75,9 +75,8 @@ template("core_snapshot") {
     tool = gen_snapshot_to_use
 
     args = [
-      # TODO(FL-117): Re-enable causal async stack traces when this issue is
-      # addressed.
       "--no_causal_async_stacks",
+      "--lazy_async_stacks",
       "--use_bytecode_compiler",
       "--enable_mirrors=false",
       "--deterministic",

diff --git a/testing/scenario_app/compile_ios_jit.sh b/testing/scenario_app/compile_ios_jit.sh
@@ -48,7 +48,8 @@ echo "Compiling JIT Snapshot..."
 
 "$DEVICE_TOOLS/gen_snapshot" --deterministic \
   --enable-asserts \
-  --causal_async_stacks \
+  --no-causal_async_stacks \
+  --lazy_async_stacks \
   --isolate_snapshot_instructions="$OUTDIR/isolate_snapshot_instr" \
   --snapshot_kind=app-jit \
   --load_vm_snapshot_data="$DEVICE_TOOLS/../gen/flutter/lib/snapshot/vm_isolate_snapshot.bin" \

diff --git a/testing/testing.gni b/testing/testing.gni
@@ -138,7 +138,8 @@ template("dart_snapshot_aot") {
     ]
 
     args = [
-      "--causal_async_stacks",
+      "--no-causal_async_stacks",
+      "--lazy_async_stacks",
       "--deterministic",
       "--snapshot_kind=app-aot-elf",
       "--elf=" + rebase_path(elf_object),