kernel: Fix bug in dynamic alert initialization

k_alert_init() needs to set the "flags" field of its associated work item to zero, indicating that the work item has not yet been submitted to the system workqueue. Using the standard work item initializer macro ensures this is done correctly. Change-Id: I0001a5920f20fb1d8dc182191e6a549c5bf89be5 Signed-off-by: Allan Stephens <[email protected]>
k0d · Nov 11, 2016 · 3cd7020 · 3cd7020
1 parent dd6f9ca
commit 3cd7020
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/kernel/unified/alert.c b/kernel/unified/alert.c
@@ -74,13 +74,9 @@ void _alert_deliver(struct k_work *work)
 void k_alert_init(struct k_alert *alert, k_alert_handler_t handler,
 		  unsigned int max_num_pending_alerts)
 {
-	const struct k_work my_work_item = {
-		NULL, _alert_deliver, { max_num_pending_alerts }
-	};
-
 	alert->handler = handler;
 	alert->send_count = ATOMIC_INIT(0);
-	alert->work_item = my_work_item;
+	alert->work_item = (struct k_work)K_WORK_INITIALIZER(_alert_deliver);
 	k_sem_init(&alert->sem, 0, max_num_pending_alerts);
 	SYS_TRACING_OBJ_INIT(k_alert, alert);
 }