x86/cpu: Fix overrun check in arch_print_cpu_modalias()

snprintf() does not return a negative value when truncating. Signed-off-by: Ben Hutchings <[email protected]> Acked-by: Thomas Renninger <[email protected]> Acked-by: H. Peter Anvin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
k1132 · Feb 13, 2012 · 70142a9 · 70142a9
1 parent da5a70f
commit 70142a9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/arch/x86/kernel/cpu/match.c b/arch/x86/kernel/cpu/match.c
@@ -67,7 +67,7 @@ ssize_t arch_print_cpu_modalias(struct device *dev,
 	for (i = 0; i < NCAPINTS*32; i++) {
 		if (boot_cpu_has(i)) {
 			n = snprintf(buf, size, ",%04X", i);
-			if (n < 0) {
+			if (n >= size) {
 				WARN(1, "x86 features overflow page\n");
 				break;
 			}