Skip to content

Commit

Permalink
[PATCH] ppc32: Make platform devices being able to assign functions
Browse files Browse the repository at this point in the history
Implemented by  modification of the .name field of the platform device,
when PDs with the
same names are to be used within different drivers, as
<device_name> -> <device_name>:<function>
Corresponding drivers should change the .name in struct device_driver to
reflect upper of course.

Added ppc_sys_device_disable/enable function set, making it easier to
disable all the inexistent/not utilized platform device way pdevs. By the
check of the "disabled" bit in the config field of ppc_sys_specs, disabled
platform devices will be either added/removed from the bus, or simply not
registered on it, depending on the time when disable/enable call asserted.

The default behaviour when nothing is disabled/enabled will be "all devices
are enabled", which is the same as before.

Also helper platform_notify_map function added, making assignment of
board-specific platform_info more consistent and generic.

Signed-off-by: Vitaly Bordug <[email protected]>
Signed-off-by: Marcelo Tosatti <[email protected]>
Signed-off-by: Paul Mackerras <[email protected]>
  • Loading branch information
Vitaly Bordug authored and paulusmack committed Feb 10, 2006
1 parent 1965746 commit 75288c7
Show file tree
Hide file tree
Showing 8 changed files with 212 additions and 3 deletions.
177 changes: 174 additions & 3 deletions arch/ppc/syslib/ppc_sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,22 @@
*/

#include <linux/string.h>
#include <linux/bootmem.h>
#include <asm/ppc_sys.h>

int (*ppc_sys_device_fixup) (struct platform_device * pdev);

static int ppc_sys_inited;
static int ppc_sys_func_inited;

static const char *ppc_sys_func_names[] = {
[PPC_SYS_FUNC_DUMMY] = "dummy",
[PPC_SYS_FUNC_ETH] = "eth",
[PPC_SYS_FUNC_UART] = "uart",
[PPC_SYS_FUNC_HLDC] = "hldc",
[PPC_SYS_FUNC_USB] = "usb",
[PPC_SYS_FUNC_IRDA] = "irda",
};

void __init identify_ppc_sys_by_id(u32 id)
{
Expand All @@ -38,13 +49,13 @@ void __init identify_ppc_sys_by_id(u32 id)
void __init identify_ppc_sys_by_name(char *name)
{
unsigned int i = 0;
while (ppc_sys_specs[i].ppc_sys_name[0])
{
while (ppc_sys_specs[i].ppc_sys_name[0]) {
if (!strcmp(ppc_sys_specs[i].ppc_sys_name, name))
break;
i++;
}
cur_ppc_sys_spec = &ppc_sys_specs[i];

return;
}

Expand Down Expand Up @@ -128,6 +139,165 @@ void ppc_sys_device_remove(enum ppc_sys_devices dev)
}
}

/* Platform-notify mapping
* Helper function for BSP code to assign board-specific platfom-divice bits
*/

void platform_notify_map(const struct platform_notify_dev_map *map,
struct device *dev)
{
struct platform_device *pdev;
int len, idx;
const char *s;

/* do nothing if no device or no bus_id */
if (!dev || !dev->bus_id)
return;

/* call per device map */
while (map->bus_id != NULL) {
idx = -1;
s = strrchr(dev->bus_id, '.');
if (s != NULL)
idx = (int)simple_strtol(s + 1, NULL, 10);
else
s = dev->bus_id;

len = s - dev->bus_id;

if (!strncmp(dev->bus_id, map->bus_id, len)) {
pdev = container_of(dev, struct platform_device, dev);
map->rtn(pdev, idx);
}
map++;
}
}

/*
Function assignment stuff.
Intended to work as follows:
the device name defined in foo_devices.c will be concatenated with :"func",
where func is string map of respective function from platfom_device_func enum
The PPC_SYS_FUNC_DUMMY function is intended to remove all assignments, making the device to appear
in platform bus with unmodified name.
*/

/*
Here we'll replace .name pointers with fixed-lenght strings
Hereby, this should be called *before* any func stuff triggeded.
*/
void ppc_sys_device_initfunc(void)
{
int i;
const char *name;
static char new_names[NUM_PPC_SYS_DEVS][BUS_ID_SIZE];
enum ppc_sys_devices cur_dev;

/* If inited yet, do nothing */
if (ppc_sys_func_inited)
return;

for (i = 0; i < cur_ppc_sys_spec->num_devices; i++) {
if ((cur_dev = cur_ppc_sys_spec->device_list[i]) < 0)
continue;

if (ppc_sys_platform_devices[cur_dev].name) {
/*backup name */
name = ppc_sys_platform_devices[cur_dev].name;
strlcpy(new_names[i], name, BUS_ID_SIZE);
ppc_sys_platform_devices[cur_dev].name = new_names[i];
}
}

ppc_sys_func_inited = 1;
}

/*The "engine" of the func stuff. Here we either concat specified function string description
to the name, or remove it if PPC_SYS_FUNC_DUMMY parameter is passed here*/
void ppc_sys_device_setfunc(enum ppc_sys_devices dev,
enum platform_device_func func)
{
char *s;
char *name = (char *)ppc_sys_platform_devices[dev].name;
char tmp[BUS_ID_SIZE];

if (!ppc_sys_func_inited) {
printk(KERN_ERR "Unable to alter function - not inited!\n");
return;
}

if (ppc_sys_inited) {
platform_device_unregister(&ppc_sys_platform_devices[dev]);
}

if ((s = (char *)strchr(name, ':')) != NULL) { /* reassign */
/* Either change the name after ':' or remove func modifications */
if (func != PPC_SYS_FUNC_DUMMY)
strlcpy(s + 1, ppc_sys_func_names[func], BUS_ID_SIZE);
else
*s = 0;
} else if (func != PPC_SYS_FUNC_DUMMY) {
/* do assignment if it is not just "clear" request */
sprintf(tmp, "%s:%s", name, ppc_sys_func_names[func]);
strlcpy(name, tmp, BUS_ID_SIZE);
}

if (ppc_sys_inited) {
platform_device_register(&ppc_sys_platform_devices[dev]);
}
}

void ppc_sys_device_disable(enum ppc_sys_devices dev)
{
BUG_ON(cur_ppc_sys_spec == NULL);

/*Check if it is enabled*/
if(!(cur_ppc_sys_spec->config[dev] & PPC_SYS_CONFIG_DISABLED)) {
if (ppc_sys_inited) {
platform_device_unregister(&ppc_sys_platform_devices[dev]);
}
cur_ppc_sys_spec->config[dev] |= PPC_SYS_CONFIG_DISABLED;
}
}

void ppc_sys_device_enable(enum ppc_sys_devices dev)
{
BUG_ON(cur_ppc_sys_spec == NULL);

/*Check if it is disabled*/
if(cur_ppc_sys_spec->config[dev] & PPC_SYS_CONFIG_DISABLED) {
if (ppc_sys_inited) {
platform_device_register(&ppc_sys_platform_devices[dev]);
}
cur_ppc_sys_spec->config[dev] &= ~PPC_SYS_CONFIG_DISABLED;
}

}

void ppc_sys_device_enable_all(void)
{
enum ppc_sys_devices cur_dev;
int i;

for (i = 0; i < cur_ppc_sys_spec->num_devices; i++) {
cur_dev = cur_ppc_sys_spec->device_list[i];
ppc_sys_device_enable(cur_dev);
}
}

void ppc_sys_device_disable_all(void)
{
enum ppc_sys_devices cur_dev;
int i;

for (i = 0; i < cur_ppc_sys_spec->num_devices; i++) {
cur_dev = cur_ppc_sys_spec->device_list[i];
ppc_sys_device_disable(cur_dev);
}
}


static int __init ppc_sys_init(void)
{
unsigned int i, dev_id, ret = 0;
Expand All @@ -136,7 +306,8 @@ static int __init ppc_sys_init(void)

for (i = 0; i < cur_ppc_sys_spec->num_devices; i++) {
dev_id = cur_ppc_sys_spec->device_list[i];
if (dev_id != -1) {
if ((dev_id != -1) &&
!(cur_ppc_sys_spec->config[dev_id] & PPC_SYS_CONFIG_DISABLED)) {
if (ppc_sys_device_fixup != NULL)
ppc_sys_device_fixup(&ppc_sys_platform_devices
[dev_id]);
Expand Down
1 change: 1 addition & 0 deletions include/asm-ppc/mpc10x.h
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ enum ppc_sys_devices {
MPC10X_DMA1,
MPC10X_UART0,
MPC10X_UART1,
NUM_PPC_SYS_DEVS,
};

int mpc10x_bridge_init(struct pci_controller *hose,
Expand Down
1 change: 1 addition & 0 deletions include/asm-ppc/mpc52xx.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ enum ppc_sys_devices {
MPC52xx_ATA,
MPC52xx_I2C1,
MPC52xx_I2C2,
NUM_PPC_SYS_DEVS,
};


Expand Down
1 change: 1 addition & 0 deletions include/asm-ppc/mpc8260.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ enum ppc_sys_devices {
MPC82xx_CPM_SMC2,
MPC82xx_CPM_USB,
MPC82xx_SEC1,
NUM_PPC_SYS_DEVS,
};

#ifndef __ASSEMBLY__
Expand Down
1 change: 1 addition & 0 deletions include/asm-ppc/mpc83xx.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ enum ppc_sys_devices {
MPC83xx_USB2_DR,
MPC83xx_USB2_MPH,
MPC83xx_MDIO,
NUM_PPC_SYS_DEVS,
};

#endif /* CONFIG_83xx */
Expand Down
1 change: 1 addition & 0 deletions include/asm-ppc/mpc85xx.h
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ enum ppc_sys_devices {
MPC85xx_eTSEC4,
MPC85xx_IIC2,
MPC85xx_MDIO,
NUM_PPC_SYS_DEVS,
};

/* Internal interrupts are all Level Sensitive, and Positive Polarity */
Expand Down
1 change: 1 addition & 0 deletions include/asm-ppc/mpc8xx.h
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ enum ppc_sys_devices {
MPC8xx_CPM_SMC1,
MPC8xx_CPM_SMC2,
MPC8xx_CPM_USB,
NUM_PPC_SYS_DEVS,
};

#define PPC_PIN_SIZE (24 * 1024 * 1024) /* 24Mbytes of data pinned */
Expand Down
32 changes: 32 additions & 0 deletions include/asm-ppc/ppc_sys.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,26 @@ struct ppc_sys_spec {
u32 value;
u32 num_devices;
char *ppc_sys_name;
u8 config[NUM_PPC_SYS_DEVS];
enum ppc_sys_devices *device_list;
};

struct platform_notify_dev_map {
const char *bus_id;
void (*rtn)(struct platform_device * pdev, int idx);
};

enum platform_device_func {
PPC_SYS_FUNC_DUMMY = 0,
PPC_SYS_FUNC_ETH = 1,
PPC_SYS_FUNC_UART = 2,
PPC_SYS_FUNC_HLDC = 3,
PPC_SYS_FUNC_USB = 4,
PPC_SYS_FUNC_IRDA = 5,
};

#define PPC_SYS_CONFIG_DISABLED 1

/* describes all specific chips and which devices they have on them */
extern struct ppc_sys_spec ppc_sys_specs[];
extern struct ppc_sys_spec *cur_ppc_sys_spec;
Expand All @@ -74,5 +91,20 @@ extern void *ppc_sys_get_pdata(enum ppc_sys_devices dev) __init;
/* remove a device from the system */
extern void ppc_sys_device_remove(enum ppc_sys_devices dev);

/* Function assignment stuff */
void ppc_sys_device_initfunc(void);
void ppc_sys_device_setfunc(enum ppc_sys_devices dev,
enum platform_device_func func);
void ppc_sys_device_set_func_all(enum platform_device_func func);

void platform_notify_map(const struct platform_notify_dev_map *map,
struct device *dev);

/* Enable / disable stuff */
void ppc_sys_device_disable(enum ppc_sys_devices dev);
void ppc_sys_device_enable(enum ppc_sys_devices dev);
void ppc_sys_device_enable_all(void);
void ppc_sys_device_disable_all(void);

#endif /* __ASM_PPC_SYS_H */
#endif /* __KERNEL__ */

0 comments on commit 75288c7

Please sign in to comment.