Skip to content

Commit

Permalink
Move sysctl check into debugging section and don't make it default y
Browse files Browse the repository at this point in the history
I noticed that sysctl_check.o was the largest object file in
a allnoconfig build in kernel/*.

  36243       0       0   36243    8d93 kernel/sysctl_check.o

This is because it was default y and && EMBEDDED. But I don't
really see a need for a non kernel developer to have their
sysctls checked all the time.

So move the Kconfig into the kernel debugging section and
also drop the default y and the EMBEDDED check.

Signed-off-by: Andi Kleen <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Andi Kleen authored and torvalds committed Aug 17, 2008
1 parent 9c0d2a2 commit 9e94cd3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 11 deletions.
11 changes: 0 additions & 11 deletions init/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -558,17 +558,6 @@ config SYSCTL_SYSCALL

If unsure say Y here.

config SYSCTL_SYSCALL_CHECK
bool "Sysctl checks" if EMBEDDED
depends on SYSCTL_SYSCALL
default y
---help---
sys_sysctl uses binary paths that have been found challenging
to properly maintain and use. This enables checks that help
you to keep things correct.

If unsure say Y here.

config KALLSYMS
bool "Load all symbols for debugging/ksymoops" if EMBEDDED
default y
Expand Down
8 changes: 8 additions & 0 deletions lib/Kconfig.debug
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,14 @@ config LATENCYTOP
Enable this option if you want to use the LatencyTOP tool
to find out which userspace is blocking on what kernel operations.

config SYSCTL_SYSCALL_CHECK
bool "Sysctl checks"
depends on SYSCTL_SYSCALL
---help---
sys_sysctl uses binary paths that have been found challenging
to properly maintain and use. This enables checks that help
you to keep things correct.

source kernel/trace/Kconfig

config PROVIDE_OHCI1394_DMA_INIT
Expand Down

0 comments on commit 9e94cd3

Please sign in to comment.