Bump RuboCop to 0.58.2

## Summary RuboCop 0.58.2 was released. https://github.com/rubocop-hq/rubocop/releases/tag/v0.58.2 And rubocop-0-58 channel is available in Code Climate. https://github.com/codeclimate/codeclimate/releases/tag/v0.76.0 qltysh/qlty@38f21f0 In addition, the following changes are made in this PR. - Replace Custom cops with Rails cops - Add jaro_winkler gem to Gemfile.lock ### Replace Custom cops with Rails cops These are compatible replacements. - Replace `CustomCops/AssertNot` cop with `Rails/AssertNot` cop. - Replace `CustomCops/RefuteNot` cop with `Rails/RefuteMethods` cop. With this replacement, it was decided to use cop of RuboCop itself. It removes the code related to CustomCops accordingly. ### Add jaro_winkler gem to Gemfile.lock Since RuboCop 0.57.0 depends on jaro_winkler gem, it has been added to Gemfile.lock.
kabelak · Jul 26, 2018 · 211b10a · 211b10a
1 parent 91fd679
commit 211b10a
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 287 deletions.
diff --git a/.codeclimate.yml b/.codeclimate.yml
@@ -23,7 +23,7 @@ checks:
 engines:
   rubocop:
     enabled: true
-    channel: rubocop-0-54
+    channel: rubocop-0-58
 
 ratings:
   paths:

diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,5 +1,3 @@
-require: './ci/custom_cops/lib/custom_cops'
-
 AllCops:
   TargetRubyVersion: 2.4
   # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
@@ -11,13 +9,16 @@ AllCops:
     - 'actionpack/lib/action_dispatch/journey/parser.rb'
     - 'railties/test/fixtures/tmp/**/*'
 
-# Prefer assert_not_x over refute_x
-CustomCops/RefuteNot:
+Rails:
+  Enabled: true
+
+# Prefer assert_not over assert !
+Rails/AssertNot:
   Include:
     - '**/test/**/*'
 
-# Prefer assert_not over assert !
-CustomCops/AssertNot:
+# Prefer assert_not_x over refute_x
+Rails/RefuteMethods:
   Include:
     - '**/test/**/*'
 

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -280,6 +280,8 @@ GEM
       mini_magick (~> 4.0)
       ruby-vips (>= 2.0.10, < 3)
     io-like (0.3.0)
+    jaro_winkler (1.5.1)
+    jaro_winkler (1.5.1-java)
     jdbc-mysql (5.1.46)
     jdbc-postgres (42.1.4)
     jdbc-sqlite3 (3.20.1)
@@ -347,13 +349,13 @@ GEM
       mini_portile2 (~> 2.3.0)
     os (0.9.6)
     parallel (1.12.1)
-    parser (2.5.1.0)
+    parser (2.5.1.2)
       ast (~> 2.4.0)
     path_expander (1.0.3)
     pg (1.0.0)
     pg (1.0.0-x64-mingw32)
     pg (1.0.0-x86-mingw32)
-    powerpack (0.1.1)
+    powerpack (0.1.2)
     psych (3.0.2)
     public_suffix (3.0.2)
     puma (3.11.4)
@@ -400,9 +402,10 @@ GEM
       resque (~> 1.26)
       rufus-scheduler (~> 3.2)
     retriable (3.1.1)
-    rubocop (0.56.0)
+    rubocop (0.58.2)
+      jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.5)
+      parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
@@ -485,7 +488,7 @@ GEM
     uber (0.1.0)
     uglifier (4.1.10)
       execjs (>= 0.3.0, < 3)
-    unicode-display_width (1.3.3)
+    unicode-display_width (1.4.0)
     useragent (0.16.10)
     vegas (0.1.11)
       rack (>= 1.0.0)

diff --git a/ci/custom_cops/bin/test b/ci/custom_cops/bin/test
diff --git a/ci/custom_cops/lib/custom_cops.rb b/ci/custom_cops/lib/custom_cops.rb
diff --git a/ci/custom_cops/lib/custom_cops/assert_not.rb b/ci/custom_cops/lib/custom_cops/assert_not.rb
diff --git a/ci/custom_cops/lib/custom_cops/refute_not.rb b/ci/custom_cops/lib/custom_cops/refute_not.rb
diff --git a/ci/custom_cops/test/custom_cops/assert_not_test.rb b/ci/custom_cops/test/custom_cops/assert_not_test.rb
diff --git a/ci/custom_cops/test/custom_cops/refute_not_test.rb b/ci/custom_cops/test/custom_cops/refute_not_test.rb
diff --git a/ci/custom_cops/test/support/cop_helper.rb b/ci/custom_cops/test/support/cop_helper.rb