fix(minor): fix dynamically changing grid properties

kabobobo · Apr 13, 2021 · 3c58fd4 · 3c58fd4
1 parent 65f25c2
commit 3c58fd4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/erpnext/accounts/doctype/bank/bank.js b/erpnext/accounts/doctype/bank/bank.js
@@ -42,7 +42,9 @@ let add_fields_to_mapping_table = function (frm) {
 		});
 	});
 
-	frm.fields_dict.bank_transaction_mapping.grid.update_docfield_property('frm.fields_dict.bank_transaction_mapping.grid', 'options', options);
+	frm.fields_dict.bank_transaction_mapping.grid.update_docfield_property(
+		'bank_transaction_field', 'options', options
+	);
 };
 
 erpnext.integrations.refreshPlaidLink = class refreshPlaidLink {

diff --git a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js
@@ -235,7 +235,7 @@ erpnext.accounts.PaymentReconciliationController = frappe.ui.form.Controller.ext
 
 		if (invoices) {
 			this.frm.fields_dict.payment.grid.update_docfield_property(
-				'invoice_number', options, "\n" + invoices.join("\n")
+				'invoice_number', 'options', "\n" + invoices.join("\n")
 			)
 
 			$.each(me.frm.doc.payments || [], function(i, p) {

diff --git a/erpnext/accounts/doctype/pos_settings/pos_settings.js b/erpnext/accounts/doctype/pos_settings/pos_settings.js
@@ -17,9 +17,7 @@ frappe.ui.form.on('POS Settings', {
 			});
 
 			frm.fields_dict.invoice_fields.grid.update_docfield_property(
-				'fieldname',
-				'options',
-				[""].concat(fields)
+				'fieldname', 'options', [""].concat(fields)
 			);
 		});