Skip to content

Commit

Permalink
driver core: bus: clean up driver_find()
Browse files Browse the repository at this point in the history
Convert the driver_find() function to use bus_to_subsys() and not use
the back-pointer to the private structure.

Cc: "Rafael J. Wysocki" <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed Feb 9, 2023
1 parent adc1850 commit fb45196
Showing 1 changed file with 15 additions and 8 deletions.
23 changes: 15 additions & 8 deletions drivers/base/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -1302,16 +1302,23 @@ EXPORT_SYMBOL_GPL(subsys_virtual_register);
*/
struct device_driver *driver_find(const char *name, struct bus_type *bus)
{
struct kobject *k = kset_find_obj(bus->p->drivers_kset, name);
struct subsys_private *sp = bus_to_subsys(bus);
struct kobject *k;
struct driver_private *priv;

if (k) {
/* Drop reference added by kset_find_obj() */
kobject_put(k);
priv = to_driver(k);
return priv->driver;
}
return NULL;
if (!sp)
return NULL;

k = kset_find_obj(sp->drivers_kset, name);
subsys_put(sp);
if (!k)
return NULL;

priv = to_driver(k);

/* Drop reference added by kset_find_obj() */
kobject_put(k);
return priv->driver;
}
EXPORT_SYMBOL_GPL(driver_find);

Expand Down

0 comments on commit fb45196

Please sign in to comment.