Added support for horizontal scrolling content #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now check for a certain y-axis touch distance and intercept if it passes the threshold. This allows us to use horizontal scrolling content such as a RecyclerView with a horizontal LinearLayoutManager inside VerticalViewPager content. Threshold may very depending on your layout. For example, if the VerticalViewPager takes up a large amount of a height, the default threshold (16dp) works perfectly. But if your VerticalViewPager takes up less than half the screen height, then a smaller threshold would provide a better user experience. For that reason, the threshold is customizable via XML with the vvp_threshold attribute. This has been tested extensively on a large-scale app that I'm currently working on.
Pkmmte
changed the title
|
Cool bro saved my time. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now check for a certain y-axis touch distance and intercept if it
passes the threshold. This allows us to use horizontal scrolling content
such as a RecyclerView with a horizontal LinearLayoutManager inside
VerticalViewPager content.
Threshold may very depending on your layout. For example, if the
VerticalViewPager takes up a large amount of a height, the default
threshold (16dp) works perfectly. But if your VerticalViewPager takes up
less than half the screen height, then a smaller threshold would provide
a better user experience. For that reason, the threshold is customizable
via XML with the vvp_threshold attribute.
This has been tested extensively on a large-scale app that I'm currently
working on.