optimize the evict parameter of channel pool at netty remoting client

kaibinHong · Sep 5, 2022 · 6f557d3 · 6f557d3
1 parent 89cc09f
commit 6f557d3
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 2 deletions.
diff --git a/tcc-transaction-core/src/main/java/org/mengyun/tcctransaction/ClientConfig.java b/tcc-transaction-core/src/main/java/org/mengyun/tcctransaction/ClientConfig.java
@@ -63,6 +63,11 @@ public long getChannelPoolTimeBetweenEvictionRunsMillis() {
         return nettyClientConfig.getChannelPoolTimeBetweenEvictionRunsMillis();
     }
 
+    @Override
+    public long getChannelPoolSoftMinEvictableIdleTimeMillis() {
+        return nettyClientConfig.getChannelPoolSoftMinEvictableIdleTimeMillis();
+    }
+
     @Override
     public int getNumTestsPerEvictionRun() {
         return nettyClientConfig.getNumTestsPerEvictionRun();

diff --git a/...e/src/main/java/org/mengyun/tcctransaction/properties/remoting/NettyClientProperties.java b/...e/src/main/java/org/mengyun/tcctransaction/properties/remoting/NettyClientProperties.java
@@ -15,6 +15,7 @@ public class NettyClientProperties extends NettyProperties implements NettyClien
     private int channelPoolMinIdlePerKey = 1;
     private long channelPoolMaxWaitMillis = 300L;
     private long channelPoolTimeBetweenEvictionRunsMillis = 10 * 1000L;
+    private long channelPoolSoftMinEvictableIdleTimeMillis = 30 * 60 * 1000L;
     private int numTestsPerEvictionRun = 2;
     //check the max idle time of client channel, if exceed, then send heartbeat message to keepalive the channel,
     //need < channelIdleTimeoutSeconds(60) in ServerConfig
@@ -111,4 +112,13 @@ public int getReconnectIntervalSeconds() {
     public void setReconnectIntervalSeconds(int reconnectIntervalSeconds) {
         this.reconnectIntervalSeconds = reconnectIntervalSeconds;
     }
+
+    @Override
+    public long getChannelPoolSoftMinEvictableIdleTimeMillis() {
+        return channelPoolSoftMinEvictableIdleTimeMillis;
+    }
+
+    public void setChannelPoolSoftMinEvictableIdleTimeMillis(long channelPoolSoftMinEvictableIdleTimeMillis) {
+        this.channelPoolSoftMinEvictableIdleTimeMillis = channelPoolSoftMinEvictableIdleTimeMillis;
+    }
 }
diff --git a/...ction-core/src/main/java/org/mengyun/tcctransaction/remoting/netty/NettyClientConfig.java b/...ction-core/src/main/java/org/mengyun/tcctransaction/remoting/netty/NettyClientConfig.java
@@ -16,6 +16,8 @@ public interface NettyClientConfig extends NettyConfig {
 
     long getChannelPoolTimeBetweenEvictionRunsMillis();
 
+    long getChannelPoolSoftMinEvictableIdleTimeMillis();
+
     int getNumTestsPerEvictionRun();
 
     int getChannelMaxIdleTimeSeconds();

diff --git a/...ion-core/src/main/java/org/mengyun/tcctransaction/remoting/netty/NettyRemotingClient.java b/...ion-core/src/main/java/org/mengyun/tcctransaction/remoting/netty/NettyRemotingClient.java
@@ -264,7 +264,7 @@ public void invokeOneway(String address, RemotingCommand request, long timeoutMi
                 @Override
                 public void operationComplete(ChannelFuture channelFuture) throws Exception {
                     if (!channelFuture.isSuccess()) {
-                        logger.warn("send a request command to channel <{}> failed.",NetUtils.parseSocketAddress(socketAddress));
+                        logger.warn("send a request command to channel <{}> failed.", NetUtils.parseSocketAddress(socketAddress));
                     }
                 }
             });
@@ -322,6 +322,8 @@ private GenericKeyedObjectPoolConfig<Channel> getChannelPoolConfig(NettyClientCo
         config.setMaxWaitMillis(nettyClientConfig.getChannelPoolMaxWaitMillis());
         config.setBlockWhenExhausted(true);
 
+        config.setMinEvictableIdleTimeMillis(-1);
+        config.setSoftMinEvictableIdleTimeMillis(nettyClientConfig.getChannelPoolSoftMinEvictableIdleTimeMillis());
 
         return config;
     }
@@ -335,4 +337,4 @@ protected void channelRead0(ChannelHandlerContext ctx, RemotingCommand cmd) thro
     }
 
 
-}
+}