Skip to content

Commit

Permalink
Avoid usage of word 'hack' in code comments
Browse files Browse the repository at this point in the history
  • Loading branch information
marcind committed Aug 17, 2012
1 parent 5582772 commit 7fb74ee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ public override Task WriteToStreamAsync(Type type, object value, Stream writeStr
Uri baseAddress = new Uri(Request.RequestUri, Request.GetConfiguration().VirtualPathRoot);

// TODO: Bug 467617: figure out the story for the operation name on the client side and server side.
// This is clearly a hack. We are assuming that the operation name is the last segment in the request uri
// This is clearly a workaround. We are assuming that the operation name is the last segment in the request uri
// which works for most cases and fall back to the type name of the object being written.
// We should rather use uri parser semantic tree to figure out the operation name from the request url.
string operationName = ODataUriHelpers.GetOperationName(Request.RequestUri, baseAddress);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public static bool TryGetEntitySetAndEntityType(Uri uri, IEdmModel model, out IE
}

// TODO: Bug 467617: figure out the story for the operation name on the client side and server side.
// This is clearly a hack. We are assuming that the operation name is the last segment in the request uri
// This is clearly a workaround. We are assuming that the operation name is the last segment in the request uri
// which works for most cases and fall back to the type name of the object being written.
// We should rather use uri parser semantic tree to figure out the operation name from the request url.
[SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification = "we really dont want to fail here and the underlying code can throw any exception")]
Expand Down

0 comments on commit 7fb74ee

Please sign in to comment.