Skip to content

Commit

Permalink
Added missing test for [ARM] AttributeParser. Check that build attribute
Browse files Browse the repository at this point in the history
Tag_Advanced_SIMD_arch is set correctly when targeting v8.1-a NEON.

Differential Revision: http://reviews.llvm.org/D13281

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@249304 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
labrinea committed Oct 5, 2015
1 parent 0eba49c commit 966b579
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions test/tools/llvm-readobj/ARM/attribute-4.s
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@
@CHECK-OBJ-NEXT: TagName: FP_arch
@CHECK-OBJ-NEXT: Description: VFPv3-D16

.eabi_attribute Tag_Advanced_SIMD_arch, 4
@CHECK: .eabi_attribute 12, 4
@CHECK-OBJ: Tag: 12
@CHECK-OBJ-NEXT: Value: 4
@CHECK-OBJ-NEXT: TagName: Advanced_SIMD_arch
@CHECK-OBJ-NEXT: Description: ARMv8.1-a NEON

.eabi_attribute Tag_PCS_config, 4
@CHECK: .eabi_attribute 13, 4
@CHECK-OBJ: Tag: 13
Expand Down
2 changes: 1 addition & 1 deletion tools/llvm-readobj/ARMAttributeParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void ARMAttributeParser::WMMX_arch(AttrType Tag, const uint8_t *Data,
void ARMAttributeParser::Advanced_SIMD_arch(AttrType Tag, const uint8_t *Data,
uint32_t &Offset) {
static const char *Strings[] = {
"Not Permitted", "NEONv1", "NEONv2+FMA", "ARMv8-a NEON"
"Not Permitted", "NEONv1", "NEONv2+FMA", "ARMv8-a NEON", "ARMv8.1-a NEON"
};

uint64_t Value = ParseInteger(Data, Offset);
Expand Down

0 comments on commit 966b579

Please sign in to comment.