Add flake8 to Travis-CI to prevent these from coming back

Added new travis make target to skip flake8 on pypy but run it on all others
kaizoku · Aug 24, 2013 · fdb2385 · fdb2385
1 parent e33c27d
commit fdb2385
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -13,7 +13,7 @@ install:
   - if [[ $TRAVIS_PYTHON_VERSION == 'pypy' ]]; then pip install astor --use-mirrors; fi
   - python setup.py -q install
 # # command to run tests
-script: nosetests
+script: make travis
 notifications:
   email:
     - [email protected]

diff --git a/Makefile b/Makefile
@@ -52,5 +52,12 @@ diff:
 
 r: d tox diff
 
+travis:
+	nosetests -s
+ifeq (PyPy,$(findstring PyPy,$(shell python -V 2>&1 | tail -1)))
+	@echo "skipping flake8 on pypy"
+else
+	flake8 hy bin tests
+endif
 
 .PHONY: docs
diff --git a/hy/util.py b/hy/util.py
@@ -25,4 +25,4 @@
 if sys.version_info[0] >= 3:
     str_type = str
 else:
-    str_type = unicode
+    str_type = unicode  # NOQA
diff --git a/requirements.txt b/requirements.txt
@@ -1,2 +1,3 @@
 # Check site / dev for more deps!
+flake8
 -e git+https://github.com/hylang/rply.git#egg=rply