Add support in excel to report last calculated val for formulas

Previously with parseexcel this was not possible. Will add more formula functionality as it's available from ruby-spreadsheet
kaktusyaka · Jun 28, 2009 · cf06814 · cf06814
1 parent 45e37e0
commit cf06814
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 19 deletions.
diff --git a/lib/roo/excel.rb b/lib/roo/excel.rb
@@ -374,7 +374,7 @@ def read_cells(sheet=nil)
       (0..row.size).each do |cell_index|
         cell = row.at(cell_index)
         next if cell.nil?  #skip empty cells
-        next if cell.class == Spreadsheet::Formula
+        next if cell.class == Spreadsheet::Formula && cell.value.nil? # skip empty formla cells
         if date_or_time?(row, cell_index)
           vt, v = read_cell_date_or_time(row, cell_index)
         else
@@ -438,6 +438,7 @@ def read_cell_date_or_time(row, idx)
   # return the values for Roo
   def read_cell(row, idx)
     cell = row.at(idx)
+    cell = cell.value if cell.class == Spreadsheet::Formula
     case cell
     when Float, Integer, Fixnum, Bignum 
       value_type = :float

diff --git a/test/numbers1_excel.csv b/test/numbers1_excel.csv