Skip to content

Commit

Permalink
Merge pull request #6 from kalinjul/update-kotlin
Browse files Browse the repository at this point in the history
update to kotlin 2.0
  • Loading branch information
kalinjul authored Jun 11, 2024
2 parents e17a0c7 + 817c4e7 commit 71d1bf5
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 50 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ Currently, the implementation is rather rudimentary.

Supported Compose version:

Compose version | EasyQRScan Version
------------------|-------------------
1.6.x | 0.1.x
1.7 | Not yet supported
| Compose version | EasyQRScan Version |
|-----------------|--------------------|
| 1.6.x | 0.1.x |
| 1.7 | Not yet supported |

# Dependency
Add the dependency to your commonMain sourceSet (KMP) / Android dependencies (android only):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,10 @@ package org.publicvalue.convention

import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.kotlin.dsl.getByType
import org.jetbrains.compose.ComposeExtension

class ComposeMultiplatformConventionPlugin : Plugin<Project> {
override fun apply(target: Project) = with(target) {
pluginManager.apply("org.jetbrains.compose")
// configureCompose()
pluginManager.apply("org.jetbrains.kotlin.plugin.compose")
}
}

//fun Project.configureCompose() {
// with(extensions.getByType<ComposeExtension>()) {
// kotlinCompilerPlugin.set(libs.versions.composeCompiler.get())
// }
//}
1 change: 1 addition & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ plugins {
alias(libs.plugins.android.application) apply false
alias(libs.plugins.android.library) apply false
alias(libs.plugins.composeMultiplatform) apply false
alias(libs.plugins.compose.compiler) apply false
alias(libs.plugins.ksp) apply false
alias(libs.plugins.kmp) apply false
alias(libs.plugins.dokka)
Expand Down
5 changes: 3 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ agp = "8.4.2"

#https://github.com/JetBrains/compose-multiplatform
compose-multiplatform = "1.6.11"
kotlin = "1.9.22"
kotlin = "2.0.0"
# https://github.com/google/ksp
ksp = "1.9.22-1.0.17"
ksp = "2.0.0-1.0.21"

#https://mvnrepository.com/artifact/org.jetbrains.compose.compiler/compiler
#composeCompiler = "1.5.8.1"
Expand Down Expand Up @@ -49,6 +49,7 @@ dokka-gradlePlugin = { module = "org.jetbrains.dokka:org.jetbrains.dokka.gradle.
android-application = { id = "com.android.application", version.ref = "agp" }
android-library = { id = "com.android.library", version.ref = "agp" }
composeMultiplatform = { id = "org.jetbrains.compose", version.ref = "compose-multiplatform" }
compose-compiler = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin" }
ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }
kmp = { id = "org.jetbrains.kotlin.multiplatform", version.ref = "kotlin"}
nexusPublish = { id = "io.github.gradle-nexus.publish-plugin", version.ref = "nexus-publish-plugin"}
Expand Down
2 changes: 1 addition & 1 deletion sample-app/android-app/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
plugins {
id("org.publicvalue.convention.android.application")
id("org.publicvalue.convention.kotlin.multiplatform.mobile")
id("org.jetbrains.compose")
id("org.publicvalue.convention.compose.multiplatform")
}

kotlin {
Expand Down
2 changes: 1 addition & 1 deletion sample-app/shared/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import org.publicvalue.convention.config.configureIosTargets
plugins {
id("org.publicvalue.convention.android.library")
id("org.publicvalue.convention.kotlin.multiplatform.mobile")
id("org.jetbrains.compose")
id("org.publicvalue.convention.compose.multiplatform")
}

kotlin {
Expand Down
2 changes: 1 addition & 1 deletion scanner/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ plugins {
id("org.publicvalue.convention.android.library")
id("org.publicvalue.convention.kotlin.multiplatform.mobile")
id("org.publicvalue.convention.centralPublish")
id("org.jetbrains.compose")
id("org.publicvalue.convention.compose.multiplatform")
}

description = "Compose Multiplatform QR Code Scanner for Android/iOS"
Expand Down
3 changes: 1 addition & 2 deletions scanner/src/iosMain/kotlin/ScannerView.kt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import platform.Foundation.NSError
import platform.QuartzCore.CALayer
import platform.QuartzCore.CATransaction
import platform.QuartzCore.kCATransactionDisableActions
import platform.UIKit.UIColor
import platform.UIKit.UIDevice
import platform.UIKit.UIDeviceOrientation
import platform.UIKit.UIView
Expand Down Expand Up @@ -190,7 +189,7 @@ class ScannerCameraCoordinator(
}
}

override fun captureOutput(output: platform.AVFoundation.AVCaptureOutput, didOutputMetadataObjects: kotlin.collections.List<*>, fromConnection: platform.AVFoundation.AVCaptureConnection) {
override fun captureOutput(output: platform.AVFoundation.AVCaptureOutput, didOutputMetadataObjects: List<*>, fromConnection: platform.AVFoundation.AVCaptureConnection) {
val metadataObject = didOutputMetadataObjects.firstOrNull() as? AVMetadataMachineReadableCodeObject
metadataObject?.stringValue?.let { onFound(it) }
}
Expand Down
30 changes: 0 additions & 30 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,36 +14,6 @@ dependencyResolutionManagement {
repositories {
mavenCentral()
google()
// workaround for https://youtrack.jetbrains.com/issue/KT-51379
exclusiveContent {
forRepository {
ivy("https://download.jetbrains.com/kotlin/native/builds") {
name = "Kotlin Native"
patternLayout {

// example download URLs:
// https://download.jetbrains.com/kotlin/native/builds/releases/1.7.20/linux-x86_64/kotlin-native-prebuilt-linux-x86_64-1.7.20.tar.gz
// https://download.jetbrains.com/kotlin/native/builds/releases/1.7.20/windows-x86_64/kotlin-native-prebuilt-windows-x86_64-1.7.20.zip
// https://download.jetbrains.com/kotlin/native/builds/releases/1.7.20/macos-x86_64/kotlin-native-prebuilt-macos-x86_64-1.7.20.tar.gz
listOf(
"macos-x86_64",
"macos-aarch64",
"osx-x86_64",
"osx-aarch64",
"linux-x86_64",
"windows-x86_64",
"iosX64"
).forEach { os ->
listOf("dev", "releases").forEach { stage ->
artifact("$stage/[revision]/$os/[artifact]-[revision].[ext]")
}
}
}
metadataSources { artifact() }
}
}
filter { includeModuleByRegex(".*", ".*kotlin-native-prebuilt.*") }
}
}
}

Expand Down

0 comments on commit 71d1bf5

Please sign in to comment.