feat(FEC-13371): Refactor: Migration to TypeScript (from Flow) #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 13, 2023 15:40
# Conflicts: # src/components/logo/logo.tsx
# Conflicts: # src/components/expandable-text/expandable-text.tsx # src/components/logo/logo.tsx # src/components/settings/settings.tsx
…r the kaltra-player types to be added, due to circular deps
### Description of the Changes Refactor: Migration to TypeScript (from Flow) Related PRs kaltura/kaltura-player-js#661 kaltura/playkit-js#726 kaltura/playkit-js-providers#225 kaltura/playkit-js-hls#213 kaltura/playkit-js-dash#254 https://github.com/kaltura/playkit-js-browserslist-config/pull/1 solves [FEC-13371](https://kaltura.atlassian.net/browse/FEC-13371) [FEC-13371]: https://kaltura.atlassian.net/browse/FEC-13371?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
# Conflicts: # kaltura-player-js.d.ts # src/components/keyboard/keyboard.tsx # src/components/player-area/player-area.tsx # src/reducers/config.ts # src/types/global.d.ts # src/types/ui-options.ts # src/ui-manager.tsx # src/utils/themes-manager.ts
fix TS export issue #### Resolves FEC-13371 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
**Export typings on package.json** #### Resolves FEC-13361 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
JonathanTGold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
solves FEC-13371
Related Prs:
kaltura/kaltura-player-js#661
kaltura/playkit-js#726
kaltura/playkit-js-providers#225
kaltura/playkit-js-dash#254
kaltura/playkit-js-hls#213
https://github.com/kaltura/playkit-js-browserslist-config/pull/1