Fix non-kernel mode #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, you're totally right. I should have had a test in there for non-kernel mode before I release. I added my own test and also moved the dsl stuff into Retriable. Thanks, I pushed a 1.4.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test to demonstrate that non-kernel mode does not work in 1.4.0. I then fixed the issue.
Along the way I removed the DSL module. It is debatable whether the Module structure is now as beautiful as it could be. I'm happy to discuss this with you and come up with a better solution that we both agree on.
My first and foremost goal however was to make it work as I intend to use the non-kernel mode in a project.