Use rubygems < v3 which supports ruby < 2.3 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kamui open to other suggestions but ran into this on another PR. Thoughts? |
|
Yeah, I'll merge this for now. Maybe I should bump the version of this gem and drop support for Ruby < 2.3 in that version. Pre 2.3 is EOL anyhow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Applying the fix proposed rubygems/rubygems#2534 (comment) / simplecov-ruby/simplecov@ba42382
Also when I uses
rubygems< 3, bundler then failed to install b/c the latest bundler required a newer version of ruby. The suggestion on the build said to usebundler`1.17.3Open to other suggestions here 😄