Put undefined in regex.error_re as well.

Rearrange code to remove the duplication and prevent future errors here.

gubernator/log_parser.py

@@ -107,9 +107,7 @@ def digest(data, objref_dict=None, filters=None, error_re=regex.error_re,
     if filters is None:
         filters = {'Namespace': '', 'UID': '', 'pod': '', 'ContainerID':''}
 
-    highlight_words = [
-        "build timed out", "error", "fail", "failed", "fatal", "undefined"
-    ]
+    highlight_words = regex.default_words
 
     if filters["pod"]:
         highlight_words = [filters["pod"]]

gubernator/regex.py

@@ -24,8 +24,11 @@ def wordRE(word):
 # Match lines with error messages
 # HACK: match ANSI colored lines by allowing preceding "m",
 # as in"\x1b[0;31mFAILED\x1b[0m"
+
+default_words = ["build timed out", "error", "fail", "failed", "fatal", "undefined"]
+
 error_re = re.compile(
-    r'(?:\b|(?<=m))(error|fatal|fail|failed|build timed out)\b', re.IGNORECASE)
+    r'(?:\b|(?<=m))(%s)\b' % '|'.join(default_words), re.IGNORECASE)
 
 # Match the dictionary string in the given line
 def objref(line):

gubernator/regex_test.py

@@ -43,6 +43,7 @@ def test_error_re(self):
             ('there was a FaTaL error', True),
             ('we failed to read logs', True),
             ('FAIL k8s.io/kubernetes/pkg/client/record', True),
+            ('undefined: someVariable', True),
             ('\x1b[0;31mFAILED\x1b[0m', True),  # color codes
         ]:
             self.assertEqual(bool(regex.error_re.search(text)), matches,