Remove hard coded password in compose file

karanrat-rattanawichai · Aug 26, 2024 · d4b77de · d4b77de
1 parent d1980c2
commit d4b77de
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -18,8 +18,8 @@ services:
     image: clickhouse/clickhouse-server:24.6
     environment:
       CLICKHOUSE_DB: analytics
-      CLICKHOUSE_USER: admin
-      CLICKHOUSE_PASSWORD: 12345678
+      CLICKHOUSE_USER: $ANALYTICS_DWH_USER
+      CLICKHOUSE_PASSWORD: $ANALYTICS_DWH_PASSWORD
     volumes:
       - ./compose/analytics-dwh/docker-entrypoint-initdb.d:/docker-entrypoint-initdb.d:ro
       - analytics-dwh-data:/var/lib/clickhouse

diff --git a/scripts/init.sh b/scripts/init.sh
@@ -67,6 +67,9 @@ echo $METABASE_DB_PASSWORD > compose/metabase-db/secrets/db_password.txt
 
 echo -n Generating compose/.env .
 cat > compose/.env <<EOF
+ANALYTICS_DWH_USER=admin
+ANALYTICS_DWH_PASSWORD=$ANALYTICS_DWH_PASSWORD
+
 DAGSTER_DB_USERNAME=postgres
 DAGSTER_DB_PASSWORD=$APP_DB_PASSWORD
 DAGSTER_CLICKHOUSE_USERNAME=admin