Fix format_diff_lines.pl triggering on deleted files

karina-ranadive · Feb 3, 2020 · 2ba95b3 · 2ba95b3
1 parent 8a94313
commit 2ba95b3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 28 deletions.
diff --git a/azure-pipelines/util/format_diff_lines.pl b/azure-pipelines/util/format_diff_lines.pl
@@ -35,6 +35,7 @@ sub push_changes {
 	}
 }
 
+# Extract ranges of added lines
 while (my $line = <STDIN>) {
 	if ($line =~ /^diff .* a\/(?<old_file>.*) b\/(?<new_file>.*)$/) {
 		# New file
@@ -43,6 +44,10 @@ sub push_changes {
 	} elsif ($line =~ /^@@ -([0-9]+)(,([0-9]+))? \+(?<new_pos>[0-9]+)(,(?<new_len>[0-9]+))? @@/) {
 		my $new_len = $+{new_len};
 		$new_len = 1 if ($new_len eq "");
+        if ($new_len == 0) {
+          # Ignore hunks with no added lines
+          next;
+        }
 		push @hunks, [$+{new_pos}, $new_len];
 	}
 }

diff --git a/azure-pipelines/util/sample.cpp b/azure-pipelines/util/sample.cpp