pybamm-team#1358 added tests to improve coverage

karthikmayil · Feb 4, 2021 · 4565460 · 4565460
1 parent 16436f5
commit 4565460
Show file tree

Hide file tree

Showing 5 changed files with 57 additions and 0 deletions.
diff --git a/tests/unit/test_models/test_full_battery_models/test_base_battery_model.py b/tests/unit/test_models/test_full_battery_models/test_base_battery_model.py
@@ -191,6 +191,10 @@ def test_options(self):
         with self.assertRaisesRegex(pybamm.OptionError, "particle cracking"):
             pybamm.BaseBatteryModel({"particle cracking": "bad particle cracking"})
 
+        # plating model
+        with self.assertRaisesRegex(pybamm.OptionError, "lithium plating"):
+            pybamm.BaseBatteryModel({"lithium plating": "bad plating"})
+
     def test_build_twice(self):
         model = pybamm.lithium_ion.SPM()  # need to pick a model to set vars and build
         with self.assertRaisesRegex(pybamm.ModelError, "Model already built"):

diff --git a/tests/unit/test_models/test_full_battery_models/test_lead_acid/test_base_lead_acid_model.py b/tests/unit/test_models/test_full_battery_models/test_lead_acid/test_base_lead_acid_model.py
@@ -26,6 +26,8 @@ def test_incompatible_options(self):
             pybamm.lead_acid.BaseModel({"dimensionality": 1, "thermal": "x-full"})
         with self.assertRaisesRegex(pybamm.OptionError, "SEI"):
             pybamm.lead_acid.BaseModel({"sei": "constant"})
+        with self.assertRaisesRegex(pybamm.OptionError, "lithium plating"):
+            pybamm.lead_acid.BaseModel({"lithium plating": "reversible"})
 
 
 if __name__ == "__main__":

diff --git a/tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_dfn.py b/tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_dfn.py
@@ -219,6 +219,23 @@ def test_well_posed_both_cracking(self):
         model.check_well_posedness()
 
 
+class TestSPMeWithPlating(unittest.TestCase):
+    def test_well_posed_none_plating(self):
+        options = {"lithium plating": "none"}
+        model = pybamm.lithium_ion.DFN(options)
+        model.check_well_posedness()
+
+    def test_well_posed_reversible_plating(self):
+        options = {"lithium plating": "reversible"}
+        model = pybamm.lithium_ion.DFN(options)
+        model.check_well_posedness()
+
+    def test_well_posed_irreversible_plating(self):
+        options = {"lithium plating": "irreversible"}
+        model = pybamm.lithium_ion.DFN(options)
+        model.check_well_posedness()
+
+
 if __name__ == "__main__":
     print("Add -v for more debug output")
     import sys

diff --git a/tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spm.py b/tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spm.py
@@ -255,6 +255,23 @@ def test_well_posed_both_cracking(self):
         model.check_well_posedness()
 
 
+class TestSPMeWithPlating(unittest.TestCase):
+    def test_well_posed_none_plating(self):
+        options = {"lithium plating": "none"}
+        model = pybamm.lithium_ion.SPM(options)
+        model.check_well_posedness()
+
+    def test_well_posed_reversible_plating(self):
+        options = {"lithium plating": "reversible"}
+        model = pybamm.lithium_ion.SPM(options)
+        model.check_well_posedness()
+
+    def test_well_posed_irreversible_plating(self):
+        options = {"lithium plating": "irreversible"}
+        model = pybamm.lithium_ion.SPM(options)
+        model.check_well_posedness()
+
+
 if __name__ == "__main__":
     print("Add -v for more debug output")
     import sys

diff --git a/tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spme.py b/tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spme.py
@@ -214,6 +214,23 @@ def test_well_posed_both_cracking(self):
         model.check_well_posedness()
 
 
+class TestSPMeWithPlating(unittest.TestCase):
+    def test_well_posed_none_plating(self):
+        options = {"lithium plating": "none"}
+        model = pybamm.lithium_ion.SPMe(options)
+        model.check_well_posedness()
+
+    def test_well_posed_reversible_plating(self):
+        options = {"lithium plating": "reversible"}
+        model = pybamm.lithium_ion.SPMe(options)
+        model.check_well_posedness()
+
+    def test_well_posed_irreversible_plating(self):
+        options = {"lithium plating": "irreversible"}
+        model = pybamm.lithium_ion.SPMe(options)
+        model.check_well_posedness()
+
+
 if __name__ == "__main__":
     print("Add -v for more debug output")
     import sys