Release v0.33.0 to Develop

Release 0.33.0 to Develop
karzak · Mar 7, 2019 · 55c0c0a · 55c0c0a
2 parents 4c50380 + d7fc4e9
commit 55c0c0a
Show file tree

Hide file tree

Showing 3 changed files with 127 additions and 100 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,112 @@
 # Changelog
 
+## 0.33.0
+
+BREAKING CHANGES
+
+* Gaia REST API
+  * [\#3641](https://github.com/cosmos/cosmos-sdk/pull/3641) Remove the ability to use a Keybase from the REST API client:
+    * `password` and `generate_only` have been removed from the `base_req` object
+    * All txs that used to sign or use the Keybase now only generate the tx
+    * `keys` routes completely removed
+  * [\#3692](https://github.com/cosmos/cosmos-sdk/pull/3692) Update tx encoding and broadcasting endpoints:
+    * Remove duplicate broadcasting endpoints in favor of POST @ `/txs`
+      * The `Tx` field now accepts a `StdTx` and not raw tx bytes
+    * Move encoding endpoint to `/txs/encode`
+
+* Gaia
+  * [\#3787](https://github.com/cosmos/cosmos-sdk/pull/3787) Fork the `x/bank` module into the Gaia application with only a
+  modified message handler, where the modified message handler behaves the same as
+  the standard `x/bank` message handler except for `MsgMultiSend` that must burn
+  exactly 9 atoms and transfer 1 atom, and `MsgSend` is disabled.
+  * [\#3789](https://github.com/cosmos/cosmos-sdk/pull/3789) Update validator creation flow:
+    * Remove `NewMsgCreateValidatorOnBehalfOf` and corresponding business logic
+    * Ensure the validator address equals the delegator address during
+    `MsgCreateValidator#ValidateBasic`
+
+* SDK
+  * [\#3750](https://github.com/cosmos/cosmos-sdk/issues/3750) Track outstanding rewards per-validator instead of globally,
+           and fix the main simulation issue, which was that slashes of
+           re-delegations to a validator were not correctly accounted for
+           in fee distribution when the redelegation in question had itself
+            been slashed (from a fault committed by a different validator)
+           in the same BeginBlock. Outstanding rewards are now available
+           on a per-validator basis in REST.
+  * [\#3669](https://github.com/cosmos/cosmos-sdk/pull/3669) Ensure consistency in message naming, codec registration, and JSON
+  tags.
+  * [\#3788](https://github.com/cosmos/cosmos-sdk/pull/3788) Change order of operations for greater accuracy when calculating delegation share token value
+  * [\#3788](https://github.com/cosmos/cosmos-sdk/pull/3788) DecCoins.Cap -> DecCoins.Intersect
+  * [\#3666](https://github.com/cosmos/cosmos-sdk/pull/3666) Improve coins denom validation.
+  * [\#3751](https://github.com/cosmos/cosmos-sdk/pull/3751) Disable (temporarily) support for ED25519 account key pairs.
+
+* Tendermint
+  * [\#3804] Update to Tendermint `v0.31.0-dev0`
+
+FEATURES
+
+* SDK
+  * [\#3719](https://github.com/cosmos/cosmos-sdk/issues/3719) DBBackend can now be set at compile time.
+    Defaults: goleveldb. Supported: cleveldb.
+
+IMPROVEMENTS
+
+* Gaia REST API
+  * Update the `TxResponse` type allowing for the `Logs` result to be JSON decoded automatically.
+
+* Gaia CLI
+  * [\#3653](https://github.com/cosmos/cosmos-sdk/pull/3653) Prompt user confirmation prior to signing and broadcasting a transaction.
+  * [\#3670](https://github.com/cosmos/cosmos-sdk/pull/3670) CLI support for showing bech32 addresses in Ledger devices
+  * [\#3711](https://github.com/cosmos/cosmos-sdk/pull/3711) Update `tx sign` to use `--from` instead of the deprecated `--name`
+  CLI flag.
+  * [\#3738](https://github.com/cosmos/cosmos-sdk/pull/3738) Improve multisig UX:
+    * `gaiacli keys show -o json` now includes constituent pubkeys, respective weights and threshold
+    * `gaiacli keys show --show-multisig` now displays constituent pubkeys, respective weights and threshold
+    * `gaiacli tx sign --validate-signatures` now displays multisig signers with their respective weights
+  * [\#3730](https://github.com/cosmos/cosmos-sdk/issues/3730) Improve workflow for
+  `gaiad gentx` with offline public keys, by outputting stdtx file that needs to be signed.
+  * [\#3761](https://github.com/cosmos/cosmos-sdk/issues/3761) Querying account related information using custom querier in auth module
+
+* SDK
+  * [\#3753](https://github.com/cosmos/cosmos-sdk/issues/3753) Remove no-longer-used governance penalty parameter
+  * [\#3679](https://github.com/cosmos/cosmos-sdk/issues/3679) Consistent operators across Coins, DecCoins, Int, Dec
+            replaced: Minus->Sub Plus->Add Div->Quo
+  * [\#3665](https://github.com/cosmos/cosmos-sdk/pull/3665) Overhaul sdk.Uint type in preparation for Coins Int -> Uint migration.
+  * [\#3691](https://github.com/cosmos/cosmos-sdk/issues/3691) Cleanup error messages
+  * [\#3456](https://github.com/cosmos/cosmos-sdk/issues/3456) Integrate in the Int.ToDec() convenience function
+  * [\#3300](https://github.com/cosmos/cosmos-sdk/pull/3300) Update the spec-spec, spec file reorg, and TOC updates.
+  * [\#3694](https://github.com/cosmos/cosmos-sdk/pull/3694) Push tagged docker images on docker hub when tag is created.
+  * [\#3716](https://github.com/cosmos/cosmos-sdk/pull/3716) Update file permissions the client keys directory and contents to `0700`.
+  * [\#3681](https://github.com/cosmos/cosmos-sdk/issues/3681) Migrate ledger-cosmos-go from ZondaX to Cosmos organization
+
+* Tendermint
+  * [\#3699](https://github.com/cosmos/cosmos-sdk/pull/3699) Upgrade to Tendermint 0.30.1
+
+BUG FIXES
+
+* Gaia CLI
+  * [\#3731](https://github.com/cosmos/cosmos-sdk/pull/3731) `keys add --interactive` bip32 passphrase regression fix
+  * [\#3714](https://github.com/cosmos/cosmos-sdk/issues/3714) Fix USB raw access issues with gaiacli when installed via snap
+
+* Gaia
+  * [\#3777](https://github.com/cosmso/cosmos-sdk/pull/3777) `gaiad export` no longer panics when the database is empty
+  * [\#3806](https://github.com/cosmos/cosmos-sdk/pull/3806) Properly return errors from a couple of struct Unmarshal functions
+
+* SDK
+  * [\#3728](https://github.com/cosmos/cosmos-sdk/issues/3728) Truncate decimal multiplication & division in distribution to ensure
+           no more than the collected fees / inflation are distributed
+  * [\#3727](https://github.com/cosmos/cosmos-sdk/issues/3727) Return on zero-length (including []byte{}) PrefixEndBytes() calls
+  * [\#3559](https://github.com/cosmos/cosmos-sdk/issues/3559) fix occasional failing due to non-determinism in lcd test TestBonding
+    where validator is unexpectedly slashed throwing off test calculations
+  * [\#3411](https://github.com/cosmos/cosmos-sdk/pull/3411) Include the `RequestInitChain.Time` in the block header init during
+  `InitChain`.
+  * [\#3717](https://github.com/cosmos/cosmos-sdk/pull/3717) Update the vesting specification and implementation to cap deduction from
+  `DelegatedVesting` by at most `DelegatedVesting`. This accounts for the case where
+  the undelegation amount may exceed the original delegation amount due to
+  truncation of undelegation tokens.
+  * [\#3717](https://github.com/cosmos/cosmos-sdk/pull/3717) Ignore unknown proposers in allocating rewards for proposers, in case
+    unbonding period was just 1 block and proposer was already deleted.
+  * [\#3726](https://github.com/cosmos/cosmos-sdk/pull/3724) Cap(clip) reward to remaining coins in AllocateTokens.
+
 ## 0.32.0
 
 BREAKING CHANGES
@@ -18,19 +125,19 @@ BREAKING CHANGES
 IMPROVEMENTS
 
 * SDK
-  * [\#3311] Reconcile the `DecCoin/s` API with the `Coin/s` API.
-  * [\#3614] Add coin denom length checks to the coins constructors.
+  * [\#3311](https://github.com/cosmos/cosmos-sdk/pull/3311) Reconcile the `DecCoin/s` API with the `Coin/s` API.
+  * [\#3614](https://github.com/cosmos/cosmos-sdk/pull/3614) Add coin denom length checks to the coins constructors.
   * [\#3621](https://github.com/cosmos/cosmos-sdk/issues/3621) remove many inter-module dependancies
-  * [\#3601] JSON-stringify the ABCI log response which includes the log and message
+  * [\#3601](https://github.com/cosmos/cosmos-sdk/pull/3601) JSON-stringify the ABCI log response which includes the log and message
   index.
-  * [\#3604] Improve SDK funds related error messages and allow for unicode in
+  * [\#3604](https://github.com/cosmos/cosmos-sdk/pull/3604) Improve SDK funds related error messages and allow for unicode in
   JSON ABCI log.
   * [\#3620](https://github.com/cosmos/cosmos-sdk/pull/3620) Version command shows build tags
-  * [\#3638] Add Bcrypt benchmarks & justification of security parameter choice
-  * [\#3648] Add JSON struct tags to vesting accounts.
+  * [\#3638](https://github.com/cosmos/cosmos-sdk/pull/3638) Add Bcrypt benchmarks & justification of security parameter choice
+  * [\#3648](https://github.com/cosmos/cosmos-sdk/pull/3648) Add JSON struct tags to vesting accounts.
 
 * Tendermint
-  * [\#3618] Upgrade to Tendermint 0.30.03
+  * [\#3618](https://github.com/cosmos/cosmos-sdk/pull/3618) Upgrade to Tendermint 0.30.03
 
 BUG FIXES
 

diff --git a/PENDING.md b/PENDING.md
@@ -6,48 +6,14 @@
 
 ### Gaia REST API
 
-* [\#3641] Remove the ability to use a Keybase from the REST API client:
-  * `password` and `generate_only` have been removed from the `base_req` object
-  * All txs that used to sign or use the Keybase now only generate the tx
-  * `keys` routes completely removed
-* [\#3692] Update tx encoding and broadcasting endpoints:
-  * Remove duplicate broadcasting endpoints in favor of POST @ `/txs`
-    * The `Tx` field now accepts a `StdTx` and not raw tx bytes
-  * Move encoding endpoint to `/txs/encode`
-
 ### Gaia CLI
 
 ### Gaia
 
-* [\#3787] Fork the `x/bank` module into the Gaia application with only a
-modified message handler, where the modified message handler behaves the same as
-the standard `x/bank` message handler except for `MsgMultiSend` that must burn
-exactly 9 atoms and transfer 1 atom, and `MsgSend` is disabled.
-* [\#3789] Update validator creation flow:
-  * Remove `NewMsgCreateValidatorOnBehalfOf` and corresponding business logic
-  * Ensure the validator address equals the delegator address during
-  `MsgCreateValidator#ValidateBasic`
-
 ### SDK
 
-* \#3750 Track outstanding rewards per-validator instead of globally,
-         and fix the main simulation issue, which was that slashes of
-         re-delegations to a validator were not correctly accounted for
-         in fee distribution when the redelegation in question had itself
-          been slashed (from a fault committed by a different validator)
-         in the same BeginBlock. Outstanding rewards are now available
-         on a per-validator basis in REST.
-* [\#3669] Ensure consistency in message naming, codec registration, and JSON
-tags.
-* #3788 Change order of operations for greater accuracy when calculating delegation share token value
-* #3788 DecCoins.Cap -> DecCoins.Intersect
-* [\#3666] Improve coins denom validation.
-* [\#3751] Disable (temporarily) support for ED25519 account key pairs.
-
 ### Tendermint
 
-* [\#3804] Update to Tendermint `v0.31.0-dev0`
-
 <!--------------------------------- FEATURES --------------------------------->
 
 ## FEATURES
@@ -60,9 +26,6 @@ tags.
 
 ### SDK
 
-* [\#3719](https://github.com/cosmos/cosmos-sdk/issues/3719) DBBackend can now be set at compile time.
-  Defaults: goleveldb. Supported: cleveldb.
-
 ### Tendermint
 
 <!------------------------------- IMPROVEMENTS ------------------------------->
@@ -71,42 +34,14 @@ tags.
 
 ### Gaia REST API
 
-* Update the `TxResponse` type allowing for the `Logs` result to be JSON
-decoded automatically.
-
 ### Gaia CLI
 
-* [\#3653] Prompt user confirmation prior to signing and broadcasting a transaction.
-* [\#3670] CLI support for showing bech32 addresses in Ledger devices
-* [\#3711] Update `tx sign` to use `--from` instead of the deprecated `--name`
-CLI flag.
-* [\#3738] Improve multisig UX:
-  * `gaiacli keys show -o json` now includes constituent pubkeys, respective weights and threshold
-  * `gaiacli keys show --show-multisig` now displays constituent pubkeys, respective weights and threshold
-  * `gaiacli tx sign --validate-signatures` now displays multisig signers with their respective weights
-* [\#3730](https://github.com/cosmos/cosmos-sdk/issues/3730) Improve workflow for
-`gaiad gentx` with offline public keys, by outputting stdtx file that needs to be signed.
-* [\#3761](https://github.com/cosmos/cosmos-sdk/issues/3761) Querying account related information using custom querier in auth module
-
 ### Gaia
 
 ### SDK
 
-* \#3753 Remove no-longer-used governance penalty parameter
-* \#3679 Consistent operators across Coins, DecCoins, Int, Dec
-          replaced: Minus->Sub Plus->Add Div->Quo
-* [\#3665] Overhaul sdk.Uint type in preparation for Coins Int -> Uint migration.
-* \#3691 Cleanup error messages
-* \#3456 Integrate in the Int.ToDec() convenience function
-* [\#3300] Update the spec-spec, spec file reorg, and TOC updates.
-* [\#3694] Push tagged docker images on docker hub when tag is created.
-* [\#3716] Update file permissions the client keys directory and contents to `0700`.
-* [\#3681](https://github.com/cosmos/cosmos-sdk/issues/3681) Migrate ledger-cosmos-go from ZondaX to Cosmos organization 
-
 ### Tendermint
 
-* [\#3699] Upgrade to Tendermint 0.30.1
-
 <!--------------------------------- BUG FIXES -------------------------------->
 
 ## BUG FIXES
@@ -115,29 +50,8 @@ CLI flag.
 
 ### Gaia CLI
 
-* [\#3731](https://github.com/cosmos/cosmos-sdk/pull/3731) `keys add --interactive` bip32 passphrase regression fix
-* [\#3714](https://github.com/cosmos/cosmos-sdk/issues/3714) Fix USB raw access issues with gaiacli when installed via snap
-
 ### Gaia
 
-* [\#3777](https://github.com/cosmso/cosmos-sdk/pull/3777) `gaiad export` no longer panics when the database is empty
-* [\#3806](https://github.com/cosmos/cosmos-sdk/pull/3806) Properly return errors from a couple of struct Unmarshal functions
-
 ### SDK
 
-* \#3728 Truncate decimal multiplication & division in distribution to ensure
-         no more than the collected fees / inflation are distributed
-* \#3727 Return on zero-length (including []byte{}) PrefixEndBytes() calls
-* \#3559 fix occasional failing due to non-determinism in lcd test TestBonding
-  where validator is unexpectedly slashed throwing off test calculations
-* [\#3411] Include the `RequestInitChain.Time` in the block header init during
-`InitChain`.
-* [\#3717] Update the vesting specification and implementation to cap deduction from
-`DelegatedVesting` by at most `DelegatedVesting`. This accounts for the case where
-the undelegation amount may exceed the original delegation amount due to
-truncation of undelegation tokens.
-* [\#3717] Ignore unknown proposers in allocating rewards for proposers, in case
-  unbonding period was just 1 block and proposer was already deleted.
-* [\#3726] Cap(clip) reward to remaining coins in AllocateTokens.
-
 ### Tendermint
diff --git a/x/distribution/simulation/invariants.go b/x/distribution/simulation/invariants.go
@@ -59,24 +59,30 @@ func CanWithdrawInvariant(k distr.Keeper, sk types.StakingKeeper) sdk.Invariant
 
 		var remaining sdk.DecCoins
 
+		valDelegationAddrs := make(map[string][]sdk.AccAddress)
+		for _, del := range sk.GetAllSDKDelegations(ctx) {
+			valAddr := del.GetValidatorAddr().String()
+			valDelegationAddrs[valAddr] = append(valDelegationAddrs[valAddr], del.GetDelegatorAddr())
+		}
+
 		// iterate over all validators
 		sk.IterateValidators(ctx, func(_ int64, val sdk.Validator) (stop bool) {
 			_ = k.WithdrawValidatorCommission(ctx, val.GetOperator())
-			// TODO fetch delegations just for the validator, requires sdk.ValidatorSet change
-			// iterate over all current delegations, withdraw rewards
-			dels := sk.GetAllSDKDelegations(ctx)
-			for _, delegation := range dels {
-				if delegation.GetValidatorAddr().String() == val.GetOperator().String() {
-					err := k.WithdrawDelegationRewards(ctx, delegation.GetDelegatorAddr(), delegation.GetValidatorAddr())
-					if err != nil {
+
+			delegationAddrs, ok := valDelegationAddrs[val.GetOperator().String()]
+			if ok {
+				for _, delAddr := range delegationAddrs {
+					if err := k.WithdrawDelegationRewards(ctx, delAddr, val.GetOperator()); err != nil {
 						panic(err)
 					}
 				}
 			}
+
 			remaining = k.GetValidatorOutstandingRewards(ctx, val.GetOperator())
 			if len(remaining) > 0 && remaining[0].Amount.LT(sdk.ZeroDec()) {
 				return true
 			}
+
 			return false
 		})