Skip to content

Commit

Permalink
Add missing check to SETCC optimization.
Browse files Browse the repository at this point in the history
PR17338.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@191337 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
eefriedman committed Sep 24, 2013
1 parent 0c5e6c6 commit 8550980
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 0 deletions.
1 change: 1 addition & 0 deletions lib/CodeGen/SelectionDAG/TargetLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1185,6 +1185,7 @@ TargetLowering::SimplifySetCC(EVT VT, SDValue N0, SDValue N1,
// the test is for equality or unsigned, and all 1 bits of the const are
// in the same partial word, see if we can shorten the load.
if (DCI.isBeforeLegalize() &&
!ISD::isSignedIntSetCC(Cond) &&
N0.getOpcode() == ISD::AND && C1 == 0 &&
N0.getNode()->hasOneUse() &&
isa<LoadSDNode>(N0.getOperand(0)) &&
Expand Down
18 changes: 18 additions & 0 deletions test/CodeGen/X86/setcc-narrowing.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
; RUN: llc < %s -mtriple=i686-apple-darwin | FileCheck %s
; PR17338

@t1.global = internal global i64 -1, align 8

define i32 @t1() nounwind ssp {
entry:
; CHECK-LABEL: t1:
; CHECK: cmpl $0, _t1.global
; CHECK-NEXT: setne %al
; CHECK-NEXT: movzbl %al, %eax
; CHECK-NEXT: ret
%0 = load i64* @t1.global, align 8
%and = and i64 4294967295, %0
%cmp = icmp sgt i64 %and, 0
%conv = zext i1 %cmp to i32
ret i32 %conv
}

0 comments on commit 8550980

Please sign in to comment.