Don't call setLibraryDebuggable when we're not debugging

kausikMR · Apr 10, 2019 · 5ae4719 · 5ae4719
1 parent 9feabb1
commit 5ae4719
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/debug/dart_debug_impl.ts b/src/debug/dart_debug_impl.ts
@@ -36,7 +36,7 @@ export class DartDebugSession extends DebugSession {
 	protected processExited = false;
 	public observatory?: ObservatoryConnection;
 	protected cwd?: string;
-	protected noDebug?: boolean;
+	public noDebug?: boolean;
 	private logFile?: string;
 	private logStream?: fs.WriteStream;
 	public debugSdkLibraries: boolean;

diff --git a/src/debug/threads.ts b/src/debug/threads.ts
@@ -90,6 +90,9 @@ export class ThreadManager {
 	}
 
 	private async setLibrariesDebuggable(isolateRef: VMIsolateRef): Promise<void> {
+		if (this.debugSession.noDebug)
+			return;
+
 		// Helpers to categories libraries as SDK/ExternalLibrary/not.
 		// Set whether libraries should be debuggable based on user settings.
 		const response = await this.debugSession.observatory.getIsolate(isolateRef.id);