Enable suggestion sets by default

package.json

@@ -1073,9 +1073,9 @@
 					"description": "Whether to call toString() on objects when rendering them in debug views (such as the Variables, Watch and Hovers views). Only applies to views of 15 or fewer values for performance reasons.",
 					"scope": "window"
 				},
-				"dart.previewAutoImportCompletions": {
+				"dart.autoImportCompletions": {
 					"type": "boolean",
-					"default": false,
+					"default": true,
 					"description": "Whether to include symbols that have not been imported in the code completion list and automatically insert the required import when selecting them.",
 					"scope": "window"
 				},

src/config.ts

@@ -33,6 +33,7 @@ class Config {
 	get analyzerObservatoryPort() { return this.getConfig<number>("analyzerObservatoryPort"); }
 	get analyzerPath() { return resolvePaths(this.getConfig<string>("analyzerPath")); }
 	get analyzerSshHost() { return this.getConfig<string>("analyzerSshHost"); }
+	get autoImportCompletions() { return this.getConfig<boolean>("autoImportCompletions"); }
 	get buildRunnerAdditionalArgs() { return this.getConfig<string[]>("buildRunnerAdditionalArgs"); }
 	get checkForSdkUpdates() { return this.getConfig<boolean>("checkForSdkUpdates"); }
 	public setCheckForSdkUpdates(value: boolean): Thenable<void> { return this.setConfig("checkForSdkUpdates", value, ConfigurationTarget.Global); }
@@ -76,7 +77,6 @@ class Config {
 	get previewHotReloadCoverageMarkers() { return this.getConfig<boolean>("previewHotReloadCoverageMarkers"); }
 	get previewBuildRunnerTasks() { return this.getConfig<boolean>("previewBuildRunnerTasks"); }
 	get previewToStringInDebugViews() { return this.getConfig<boolean>("previewToStringInDebugViews"); }
-	get previewAutoImportCompletions() { return this.getConfig<boolean>("previewAutoImportCompletions"); }
 
 	// Helpers
 	get useDarkTheme() { return this.theme !== "light"; }

src/extension.ts

@@ -316,7 +316,7 @@ export function activate(context: vs.ExtensionContext, isRestart: boolean = fals
 		context.subscriptions.push(new OpenFileTracker(analyzer));
 
 		// Set up completions for unimported items.
-		if (analyzer.capabilities.supportsAvailableSuggestions && config.previewAutoImportCompletions) {
+		if (analyzer.capabilities.supportsAvailableSuggestions && config.autoImportCompletions) {
 			analyzer.completionSetSubscriptions({
 				subscriptions: ["AVAILABLE_SUGGESTION_SETS"],
 			});

test/dart_only/providers/completion_item_provider.test.ts

@@ -107,9 +107,7 @@ main() {
 		assert.equal(completion.detail, "(int i) → int"); // No auto import message here
 	});
 
-	it("sorts completions by relevance", async () => {
-		throw new Error("NYI");
-	});
+	it.skip("sorts completions by relevance");
 
 	it("inserts full text for overrides", async () => {
 		await setTestContent(`

test/test_projects/hello_world/.vscode/settings.json

@@ -9,5 +9,4 @@
 		"lib/excluded"
 	],
 	"dart.showIgnoreQuickFixes": true,
-	"dart.previewAutoImportCompletions": true,
 }