fix: starting position of if statement (robertkrimen#501)

Fix IfStatement Idx0 to point to the right place. I was pointing to the right parenthesis after the test expression.
kavanahuang · Jul 17, 2023 · f70d418 · f70d418
1 parent ea8bcc3
commit f70d418
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/parser/parser_test.go b/parser/parser_test.go
@@ -1022,7 +1022,8 @@ func TestPosition(t *testing.T) {
 		is(err, nil)
 		block := program.Body[0].(*ast.ExpressionStatement).Expression.(*ast.FunctionLiteral).Body.(*ast.BlockStatement)
 		node = block.List[0].(*ast.IfStatement)
-		is(node.Idx0(), 21)
+		is(node.Idx0(), 14)
+		is(parser.slice(node.Idx0(), node.Idx1()), "if (abc) { throw 'failed'; }")
 		node = node.(*ast.IfStatement).Consequent.(*ast.BlockStatement).List[0].(*ast.ThrowStatement)
 		is(node.Idx0(), 39)
 	})

diff --git a/parser/statement.go b/parser/statement.go
@@ -722,15 +722,15 @@ func (p *parser) parseIfStatement() ast.Statement {
 	if p.mode&StoreComments != 0 {
 		comments = p.comments.FetchAll()
 	}
-	p.expect(token.IF)
+	pos := p.expect(token.IF)
 	var ifComments []*ast.Comment
 	if p.mode&StoreComments != 0 {
 		ifComments = p.comments.FetchAll()
 	}
 
 	p.expect(token.LEFT_PARENTHESIS)
 	node := &ast.IfStatement{
-		If:   p.idx,
+		If:   pos,
 		Test: p.parseExpression(),
 	}
 	p.expect(token.RIGHT_PARENTHESIS)