Skip to content

Commit

Permalink
mips: dts: align LED node names with dtschema
Browse files Browse the repository at this point in the history 
The node names should be generic and DT schema expects certain pattern:

  mt7621-gnubee-gb-pc1.dtb: gpio-leds: 'power', 'system' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Signed-off-by: Arınç ÜNAL <[email protected]>
Reviewed-by: Sergio Paracuellos <[email protected]>
Signed-off-by: Thomas Bogendoerfer <[email protected]>
  • Loading branch information
@arinc9 @tsbogend
arinc9 authored and tsbogend committed Feb 17, 2023
1 parent 159c610 commit 09e61ef
Show file tree
Hide file tree
Showing 11 changed files with 47 additions and 47 deletions.
10 changes: 5 additions & 5 deletions arch/mips/boot/dts/cavium-octeon/dlink_dsr-1000n.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,27 @@
leds {
compatible = "gpio-leds";

usb1 {
led-usb1 {
label = "usb1";
gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
};

usb2 {
led-usb2 {
label = "usb2";
gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
};

wps {
led-wps {
label = "wps";
gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
};

wireless1 {
led-wireless1 {
label = "5g";
gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
};

wireless2 {
led-wireless2 {
label = "2.4g";
gpios = <&gpio 18 GPIO_ACTIVE_LOW>;
};
Expand Down
6 changes: 3 additions & 3 deletions arch/mips/boot/dts/cavium-octeon/dlink_dsr-500n.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
leds {
compatible = "gpio-leds";

usb {
led-usb {
gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
};

wps {
led-wps {
gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
};

wireless {
led-wireless {
label = "2.4g";
gpios = <&gpio 18 GPIO_ACTIVE_LOW>;
};
Expand Down
8 changes: 4 additions & 4 deletions arch/mips/boot/dts/ingenic/ci20.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,25 +42,25 @@
leds {
compatible = "gpio-leds";

led0 {
led-0 {
label = "ci20:red:led0";
gpios = <&gpc 3 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "none";
};

led1 {
led-1 {
label = "ci20:red:led1";
gpios = <&gpc 2 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "nand-disk";
};

led2 {
led-2 {
label = "ci20:red:led2";
gpios = <&gpc 1 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "cpu1";
};

led3 {
led-3 {
label = "ci20:red:led3";
gpios = <&gpc 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "cpu0";
Expand Down
6 changes: 3 additions & 3 deletions arch/mips/boot/dts/pic32/pic32mzda_sk.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,19 @@
pinctrl-names = "default";
pinctrl-0 = <&user_leds_s0>;

led@1 {
led-1 {
label = "pic32mzda_sk:red:led1";
gpios = <&gpio7 0 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};

led@2 {
led-2 {
label = "pic32mzda_sk:yellow:led2";
gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "mmc0";
};

led@3 {
led-3 {
label = "pic32mzda_sk:green:led3";
gpios = <&gpio7 2 GPIO_ACTIVE_HIGH>;
default-state = "on";
Expand Down
8 changes: 4 additions & 4 deletions arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,23 @@

leds {
compatible = "gpio-leds";
led@0 {
led-0 {
label = "tp-link:green:usb";
gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
};

led@1 {
led-1 {
label = "tp-link:green:system";
gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};

led@2 {
led-2 {
label = "tp-link:green:qss";
gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
};

led@3 {
led-3 {
label = "tp-link:green:wlan";
gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
};
Expand Down
8 changes: 4 additions & 4 deletions arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,25 @@
leds {
compatible = "gpio-leds";

wlan {
led-wlan {
label = "dragino2:red:wlan";
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

lan {
led-lan {
label = "dragino2:red:lan";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
default-state = "off";
};

wan {
led-wan {
label = "dragino2:red:wan";
gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
default-state = "off";
};

system {
led-system {
label = "dragino2:red:system";
gpios = <&gpio 28 GPIO_ACTIVE_HIGH>;
default-state = "off";
Expand Down
2 changes: 1 addition & 1 deletion arch/mips/boot/dts/qca/ar9331_omega.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
leds {
compatible = "gpio-leds";

system {
led-system {
label = "onion:amber:system";
gpios = <&gpio 27 GPIO_ACTIVE_LOW>;
default-state = "off";
Expand Down
8 changes: 4 additions & 4 deletions arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,25 @@
leds {
compatible = "gpio-leds";

wlan {
led-wlan {
label = "tp-link:green:wlan";
gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

lan {
led-lan {
label = "tp-link:green:lan";
gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
default-state = "off";
};

wps {
led-wps {
label = "tp-link:green:wps";
gpios = <&gpio 26 GPIO_ACTIVE_LOW>;
default-state = "off";
};

led3g {
led-led3g {
label = "tp-link:green:3g";
gpios = <&gpio 27 GPIO_ACTIVE_LOW>;
default-state = "off";
Expand Down
22 changes: 11 additions & 11 deletions arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,67 +47,67 @@
* (see below). So we can't include it in this LED node.
*/

power_blue {
led-power-blue {
label = "smartgw:power:blue";
gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

power_green {
led-power-green {
label = "smartgw:power:green";
gpios = <&gpio 19 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

power_red {
led-power-red {
label = "smartgw:power:red";
gpios = <&gpio 22 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

radio_blue {
led-radio-blue {
label = "smartgw:radio:blue";
gpios = <&gpio 23 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

radio_green {
led-radio-green {
label = "smartgw:radio:green";
gpios = <&gpio 24 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

radio_red {
led-radio-red {
label = "smartgw:radio:red";
gpios = <&gpio 25 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

internet_blue {
led-internet-blue {
label = "smartgw:internet:blue";
gpios = <&gpio 26 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

internet_green {
led-internet-green {
label = "smartgw:internet:green";
gpios = <&gpio 27 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

internet_red {
led-internet-red {
label = "smartgw:internet:red";
gpios = <&gpio 28 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

ethernet_link {
led-ethernet-link {
label = "smartgw:eth:link";
gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
linux,default-trigger = "netdev";
};

ethernet_activity {
led-ethernet-activity {
label = "smartgw:eth:act";
gpios = <&gpio 43 GPIO_ACTIVE_LOW>;
linux,default-trigger = "netdev";
Expand Down
4 changes: 2 additions & 2 deletions arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc1.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
gpio-leds {
compatible = "gpio-leds";

power {
led-power {
label = "green:power";
gpios = <&gpio 6 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-on";
};

system {
led-system {
label = "green:system";
gpios = <&gpio 8 GPIO_ACTIVE_LOW>;
linux,default-trigger = "disk-activity";
Expand Down
12 changes: 6 additions & 6 deletions arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,33 +33,33 @@
gpio-leds {
compatible = "gpio-leds";

ethblack-green {
led-ethblack-green {
label = "green:ethblack";
gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
};

ethblue-green {
led-ethblue-green {
label = "green:ethblue";
gpios = <&gpio 4 GPIO_ACTIVE_LOW>;
};

ethyellow-green {
led-ethyellow-green {
label = "green:ethyellow";
gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
};

ethyellow-orange {
led-ethyellow-orange {
label = "orange:ethyellow";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
};

power {
led-power {
label = "green:power";
gpios = <&gpio 6 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-on";
};

system {
led-system {
label = "green:system";
gpios = <&gpio 8 GPIO_ACTIVE_LOW>;
linux,default-trigger = "disk-activity";
Expand Down

0 comments on commit 09e61ef

Please sign in to comment.