Skip to content

Commit

Permalink
parport: load lowlevel driver if ports not found
Browse files Browse the repository at this point in the history
Usually all the distro will load the parport low level driver as part
of their initialization. But we can get into a situation where all the
parallel port drivers are built as module and we unload all the modules
at a later time. Then if we just do "modprobe parport" it will only
load the parport module and will not load the low level driver which
will actually register the ports. So, check the bus if there is any
parport registered, if not, load the low level driver.

We can get into the above situation with all distro but only Suse has
setup the alias for "parport_lowlevel" and so it only works in Suse.
Users of Debian based distro will need to load the lowlevel module
manually.

Signed-off-by: Sudip Mukherjee <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
sudipm-mukherjee authored and gregkh committed Nov 13, 2019
1 parent e962cd9 commit 231ec2f
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions drivers/parport/share.c
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,18 @@ static int port_check(struct device *dev, void *dev_drv)
return 0;
}

/*
* Iterates through all the devices connected to the bus and return 1
* if the device is a parallel port.
*/

static int port_detect(struct device *dev, void *dev_drv)
{
if (is_parport(dev))
return 1;
return 0;
}

/**
* parport_register_driver - register a parallel port device driver
* @drv: structure describing the driver
Expand Down Expand Up @@ -279,6 +291,15 @@ int __parport_register_driver(struct parport_driver *drv, struct module *owner,
if (ret)
return ret;

/*
* check if bus has any parallel port registered, if
* none is found then load the lowlevel driver.
*/
ret = bus_for_each_dev(&parport_bus_type, NULL, NULL,
port_detect);
if (!ret)
get_lowlevel_driver();

mutex_lock(&registration_lock);
if (drv->match_port)
bus_for_each_dev(&parport_bus_type, NULL, drv,
Expand Down

0 comments on commit 231ec2f

Please sign in to comment.