kbuild: reduce the number of mkdir calls during modules_install

Calling 'mkdir' for every module results in redundant syscalls. Use $(sort ...) to drop the duplicated directories. Signed-off-by: Masahiro Yamada <[email protected]> Reviewed-by: Nicolas Schier <[email protected]>
kawasaki · Sep 1, 2023 · 2dfec88 · 2dfec88
1 parent d8131c2
commit 2dfec88
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
@@ -9,6 +9,8 @@ __modinst:
 include include/config/auto.conf
 include $(srctree)/scripts/Kbuild.include
 
+install-y :=
+
 modules := $(call read-file, $(MODORDER))
 
 ifeq ($(KBUILD_EXTMOD),)
@@ -27,6 +29,7 @@ suffix-$(CONFIG_MODULE_COMPRESS_XZ)	:= .xz
 suffix-$(CONFIG_MODULE_COMPRESS_ZSTD)	:= .zst
 
 modules := $(patsubst $(extmod_prefix)%.o, $(dst)/%.ko$(suffix-y), $(modules))
+install-$(CONFIG_MODULES) += $(modules)
 
 __modinst: $(modules)
 	@:
@@ -35,7 +38,7 @@ __modinst: $(modules)
 # Installation
 #
 quiet_cmd_install = INSTALL $@
-      cmd_install = mkdir -p $(dir $@); cp $< $@
+      cmd_install = cp $< $@
 
 # Strip
 #
@@ -81,6 +84,9 @@ endif
 
 ifeq ($(modules_sign_only),)
 
+# Create necessary directories
+$(shell mkdir -p $(sort $(dir $(install-y))))
+
 $(dst)/%.ko: $(extmod_prefix)%.ko FORCE
 	$(call cmd,install)
 	$(call cmd,strip)