block: get rid of useless goto and label in blk_mq_get_new_requests()

Expected case is returning a request, just check for success and return the request rather than having an error label. Signed-off-by: Jens Axboe <[email protected]>
kawasaki · Dec 2, 2021 · 373b541 · 373b541
1 parent 18d7817
commit 373b541
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/block/blk-mq.c b/block/blk-mq.c
@@ -2720,11 +2720,8 @@ static struct request *blk_mq_get_new_requests(struct request_queue *q,
 	}
 
 	rq = __blk_mq_alloc_requests(&data);
-	if (!rq)
-		goto fail;
-	return rq;
-
-fail:
+	if (rq)
+		return rq;
 	rq_qos_cleanup(q, bio);
 	if (bio->bi_opf & REQ_NOWAIT)
 		bio_wouldblock_error(bio);