Skip to content

Commit

Permalink
drm/imx: imx-tve: Delete an error message in imx_tve_bind()
Browse files Browse the repository at this point in the history
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
Signed-off-by: Philipp Zabel <[email protected]>
  • Loading branch information
elfring authored and pH5 committed Jul 20, 2020
1 parent dd81d82 commit 408a85e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/gpu/drm/imx/imx-tve.c
Original file line number Diff line number Diff line change
Expand Up @@ -591,10 +591,8 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data)
}

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(dev, "failed to get irq\n");
if (irq < 0)
return irq;
}

ret = devm_request_threaded_irq(dev, irq, NULL,
imx_tve_irq_handler, IRQF_ONESHOT,
Expand Down

0 comments on commit 408a85e

Please sign in to comment.