Skip to content

Commit

Permalink
can: m_can: Always acknowledge all interrupts
Browse files Browse the repository at this point in the history
The code already exits the function on !ir before this condition. No
need to check again if anything is set as IR_ALL_INT is 0xffffffff.

Signed-off-by: Markus Schneider-Pargmann <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Link: https://lore.kernel.org/all/[email protected]
Signed-off-by: Marc Kleine-Budde <[email protected]>
  • Loading branch information
scosu authored and marckleinebudde committed Mar 24, 2023
1 parent 7304293 commit 4ab6394
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/can/m_can/m_can.c
Original file line number Diff line number Diff line change
Expand Up @@ -1083,8 +1083,7 @@ static irqreturn_t m_can_isr(int irq, void *dev_id)
return IRQ_NONE;

/* ACK all irqs */
if (ir & IR_ALL_INT)
m_can_write(cdev, M_CAN_IR, ir);
m_can_write(cdev, M_CAN_IR, ir);

if (cdev->ops->clear_interrupts)
cdev->ops->clear_interrupts(cdev);
Expand Down

0 comments on commit 4ab6394

Please sign in to comment.