Skip to content

Commit

Permalink
jffs2: Replace zero-length array with flexible-array
Browse files Browse the repository at this point in the history
There is a regular need in the kernel to provide a way to declare having a
dynamically sized set of trailing elements in a structure. Kernel code should
always use “flexible array members”[1] for these cases. The older style of
one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] KSPP#21

Signed-off-by: Gustavo A. R. Silva <[email protected]>
  • Loading branch information
GustavoARSilva committed Jun 16, 2020
1 parent 8192e60 commit 6112bad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion fs/jffs2/nodelist.h
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ struct jffs2_full_dirent
uint32_t ino; /* == zero for unlink */
unsigned int nhash;
unsigned char type;
unsigned char name[0];
unsigned char name[];
};

/*
Expand Down
4 changes: 2 additions & 2 deletions fs/jffs2/summary.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ struct jffs2_sum_dirent_flash
jint32_t ino; /* == zero for unlink */
uint8_t nsize; /* dirent name size */
uint8_t type; /* dirent type */
uint8_t name[0]; /* dirent name */
uint8_t name[]; /* dirent name */
} __attribute__((packed));

struct jffs2_sum_xattr_flash
Expand Down Expand Up @@ -117,7 +117,7 @@ struct jffs2_sum_dirent_mem
jint32_t ino; /* == zero for unlink */
uint8_t nsize; /* dirent name size */
uint8_t type; /* dirent type */
uint8_t name[0]; /* dirent name */
uint8_t name[]; /* dirent name */
} __attribute__((packed));

struct jffs2_sum_xattr_mem
Expand Down

0 comments on commit 6112bad

Please sign in to comment.