Skip to content

Commit

Permalink
net: dsa: microchip: remove IRQF_TRIGGER_FALLING in request_threaded_irq
Browse files Browse the repository at this point in the history
KSZ swithes used interrupts for detecting the phy link up and down.
During registering the interrupt handler, it used IRQF_TRIGGER_FALLING
flag. But this flag has to be retrieved from device tree instead of hard
coding in the driver, so removing the flag.

Fixes: ff319a6 ("net: dsa: microchip: move interrupt handling logic from lan937x to ksz_common")
Reported-by: Christian Eggers <[email protected]>
Signed-off-by: Arun Ramadoss <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
  • Loading branch information
Arun Ramadoss authored and kuba-moo committed Dec 20, 2022
1 parent 2856a62 commit 62e027f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/dsa/microchip/ksz_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1996,8 +1996,7 @@ static int ksz_irq_common_setup(struct ksz_device *dev, struct ksz_irq *kirq)
irq_create_mapping(kirq->domain, n);

ret = request_threaded_irq(kirq->irq_num, NULL, ksz_irq_thread_fn,
IRQF_ONESHOT | IRQF_TRIGGER_FALLING,
kirq->name, kirq);
IRQF_ONESHOT, kirq->name, kirq);
if (ret)
goto out;

Expand Down

0 comments on commit 62e027f

Please sign in to comment.