Skip to content

Commit

Permalink
crypto: glue_helper - remove the le128_gf128mul_x_ble function
Browse files Browse the repository at this point in the history
The le128_gf128mul_x_ble function in glue_helper.h is now obsolete and
can be replaced with the gf128mul_x_ble function from gf128mul.h.

Signed-off-by: Ondrej Mosnacek <[email protected]>
Reviewd-by: Eric Biggers <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
WOnder93 authored and herbertx committed Apr 5, 2017
1 parent e55318c commit 692016b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
3 changes: 2 additions & 1 deletion arch/x86/crypto/glue_helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

#include <linux/module.h>
#include <crypto/b128ops.h>
#include <crypto/gf128mul.h>
#include <crypto/internal/skcipher.h>
#include <crypto/lrw.h>
#include <crypto/xts.h>
Expand Down Expand Up @@ -457,7 +458,7 @@ void glue_xts_crypt_128bit_one(void *ctx, u128 *dst, const u128 *src, le128 *iv,
le128 ivblk = *iv;

/* generate next IV */
le128_gf128mul_x_ble(iv, &ivblk);
gf128mul_x_ble(iv, &ivblk);

/* CC <- T xor C */
u128_xor(dst, src, (u128 *)&ivblk);
Expand Down
10 changes: 0 additions & 10 deletions arch/x86/include/asm/crypto/glue_helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -125,16 +125,6 @@ static inline void le128_inc(le128 *i)
i->b = cpu_to_le64(b);
}

static inline void le128_gf128mul_x_ble(le128 *dst, const le128 *src)
{
u64 a = le64_to_cpu(src->a);
u64 b = le64_to_cpu(src->b);
u64 _tt = ((s64)a >> 63) & 0x87;

dst->a = cpu_to_le64((a << 1) ^ (b >> 63));
dst->b = cpu_to_le64((b << 1) ^ _tt);
}

extern int glue_ecb_crypt_128bit(const struct common_glue_ctx *gctx,
struct blkcipher_desc *desc,
struct scatterlist *dst,
Expand Down

0 comments on commit 692016b

Please sign in to comment.