ext4: fix possible double unlock when moving a directory

Fixes: 0813299 ("ext4: Fix possible corruption when moving a directory") Link: https://lore.kernel.org/r/[email protected] Reported-by: Dan Carpenter <[email protected]> Reported-by: [email protected] Signed-off-by: Theodore Ts'o <[email protected]>
kawasaki · Mar 18, 2023 · 70e42fe · 70e42fe
1 parent eeac8ed
commit 70e42fe
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
@@ -3884,10 +3884,8 @@ static int ext4_rename(struct mnt_idmap *idmap, struct inode *old_dir,
 				goto end_rename;
 		}
 		retval = ext4_rename_dir_prepare(handle, &old);
-		if (retval) {
-			inode_unlock(old.inode);
+		if (retval)
 			goto end_rename;
-		}
 	}
 	/*
 	 * If we're renaming a file within an inline_data dir and adding or