Skip to content

Commit

Permalink
mm: nobootmem: move the comment of free_all_bootmem
Browse files Browse the repository at this point in the history
Commit b4def35 ("mm, nobootmem: clean-up of free_low_memory_core_early()")
removed the unnecessary nodeid argument, after that, this comment
becomes more confused.  We should move it to the right place.

Fixes: b4def35 ("mm, nobootmem: clean-up of free_low_memory_core_early()")
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Wanlong Gao <[email protected]>
Cc: Joonsoo Kim <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
gaowanlong authored and torvalds committed Oct 8, 2016
1 parent 19938e3 commit 914a051
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions mm/nobootmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@ static unsigned long __init free_low_memory_core_early(void)
for_each_reserved_mem_region(i, &start, &end)
reserve_bootmem_region(start, end);

/*
* We need to use NUMA_NO_NODE instead of NODE_DATA(0)->node_id
* because in some case like Node0 doesn't have RAM installed
* low ram will be on Node1
*/
for_each_free_mem_range(i, NUMA_NO_NODE, MEMBLOCK_NONE, &start, &end,
NULL)
count += __free_memory_core(start, end);
Expand Down Expand Up @@ -194,11 +199,6 @@ unsigned long __init free_all_bootmem(void)

reset_all_zones_managed_pages();

/*
* We need to use NUMA_NO_NODE instead of NODE_DATA(0)->node_id
* because in some case like Node0 doesn't have RAM installed
* low ram will be on Node1
*/
pages = free_low_memory_core_early();
totalram_pages += pages;

Expand Down

0 comments on commit 914a051

Please sign in to comment.