Skip to content

Commit

Permalink
firmware: include drivers/firmware/Kconfig unconditionally
Browse files Browse the repository at this point in the history
Compile-testing drivers that require access to a firmware layer
fails when that firmware symbol is unavailable. This happened
twice this week:

 - My proposed to change to rework the QCOM_SCM firmware symbol
   broke on ppc64 and others.

 - The cs_dsp firmware patch added device specific firmware loader
   into drivers/firmware, which broke on the same set of
   architectures.

We should probably do the same thing for other subsystems as well,
but fix this one first as this is a dependency for other patches
getting merged.

Reviewed-by: Bjorn Andersson <[email protected]>
Reviewed-by: Charles Keepax <[email protected]>
Acked-by: Will Deacon <[email protected]>
Acked-by: Bjorn Andersson <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Liam Girdwood <[email protected]>
Cc: Charles Keepax <[email protected]>
Cc: Simon Trimmer <[email protected]>
Cc: Michael Ellerman <[email protected]>
Reviewed-by: Mark Brown <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
  • Loading branch information
arndb committed Oct 7, 2021
1 parent 6880fa6 commit 951cd3a
Show file tree
Hide file tree
Showing 8 changed files with 2 additions and 14 deletions.
2 changes: 0 additions & 2 deletions arch/arm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1989,8 +1989,6 @@ config ARCH_HIBERNATION_POSSIBLE

endmenu

source "drivers/firmware/Kconfig"

if CRYPTO
source "arch/arm/crypto/Kconfig"
endif
Expand Down
2 changes: 0 additions & 2 deletions arch/arm64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1931,8 +1931,6 @@ source "drivers/cpufreq/Kconfig"

endmenu

source "drivers/firmware/Kconfig"

source "drivers/acpi/Kconfig"

source "arch/arm64/kvm/Kconfig"
Expand Down
2 changes: 0 additions & 2 deletions arch/ia64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,6 @@ config CRASH_DUMP
help
Generate crash dump after being started by kexec.

source "drivers/firmware/Kconfig"

endmenu

menu "Power management and ACPI options"
Expand Down
2 changes: 0 additions & 2 deletions arch/mips/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3316,8 +3316,6 @@ source "drivers/cpuidle/Kconfig"

endmenu

source "drivers/firmware/Kconfig"

source "arch/mips/kvm/Kconfig"

source "arch/mips/vdso/Kconfig"
2 changes: 0 additions & 2 deletions arch/parisc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,4 @@ config KEXEC_FILE

endmenu

source "drivers/firmware/Kconfig"

source "drivers/parisc/Kconfig"
2 changes: 0 additions & 2 deletions arch/riscv/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -561,5 +561,3 @@ menu "Power management options"
source "kernel/power/Kconfig"

endmenu

source "drivers/firmware/Kconfig"
2 changes: 0 additions & 2 deletions arch/x86/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2828,8 +2828,6 @@ config HAVE_ATOMIC_IOMAP
def_bool y
depends on X86_32

source "drivers/firmware/Kconfig"

source "arch/x86/kvm/Kconfig"

source "arch/x86/Kconfig.assembler"
2 changes: 2 additions & 0 deletions drivers/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ source "drivers/bus/Kconfig"

source "drivers/connector/Kconfig"

source "drivers/firmware/Kconfig"

source "drivers/gnss/Kconfig"

source "drivers/mtd/Kconfig"
Expand Down

0 comments on commit 951cd3a

Please sign in to comment.