HSI: core: Fix return freed object in hsi_new_client

cl is freed on error of calling device_register, but this object is return later, which will cause uaf issue. Fix it by return NULL on error. Signed-off-by: Chengfeng Ye <[email protected]> Signed-off-by: Sebastian Reichel <[email protected]>
kawasaki · Nov 25, 2021 · a1ee1c0 · a1ee1c0
1 parent fa55b7d
commit a1ee1c0
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/drivers/hsi/hsi_core.c b/drivers/hsi/hsi_core.c
@@ -102,6 +102,7 @@ struct hsi_client *hsi_new_client(struct hsi_port *port,
 	if (device_register(&cl->device) < 0) {
 		pr_err("hsi: failed to register client: %s\n", info->name);
 		put_device(&cl->device);
+		goto err;
 	}
 
 	return cl;