Skip to content

Commit

Permalink
initramfs: replace klibcdirs in Makefile with FORCE
Browse files Browse the repository at this point in the history
'klibcdirs' was added by commit d39a206 ("kbuild: rebuild initramfs
if content of initramfs changes"). If this is just a matter of forcing
execution of the recipe line, we can replace it with FORCE.

The following code is currently useless:

   $(deps_initramfs): klibcdirs

The original intent could be a hook for the klibc integration into the
kernel tree, but klibc is a separate project, which can be built
independently. Clean it up.

Signed-off-by: Masahiro Yamada <[email protected]>
Reviewed-by: Greg Thelen <[email protected]>
  • Loading branch information
masahir0y committed Jan 14, 2020
1 parent 9945722 commit a2183c0
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions usr/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
# kbuild file for usr/ - including initramfs image
#

klibcdirs:;
PHONY += klibcdirs

suffix_y = $(subst $\",,$(CONFIG_INITRAMFS_COMPRESSION))
datafile_y = initramfs_data.cpio$(suffix_y)
datafile_d_y = .$(datafile_y).d
Expand Down Expand Up @@ -50,13 +47,12 @@ targets := $(datafile_y)
# do not try to update files included in initramfs
$(deps_initramfs): ;

$(deps_initramfs): klibcdirs
# We rebuild initramfs_data.cpio if:
# 1) Any included file is newer than initramfs_data.cpio
# 2) There are changes in which files are included (added or deleted)
# 3) If gen_init_cpio are newer than initramfs_data.cpio
# 4) Arguments to gen_initramfs.sh changes
$(obj)/$(datafile_y): $(obj)/gen_init_cpio $(deps_initramfs) klibcdirs
$(obj)/$(datafile_y): $(obj)/gen_init_cpio $(deps_initramfs) FORCE
$(Q)$(initramfs) -l $(ramfs-input) > $(obj)/$(datafile_d_y)
$(call if_changed,initfs)

Expand Down

0 comments on commit a2183c0

Please sign in to comment.