Skip to content

Commit

Permalink
x86, asm: Fix ancient-GAS workaround
Browse files Browse the repository at this point in the history
It turns out to generate something like this:

    printk ( ("<3>") "something");

The extra parentheses here break the UML compile.

Change the sed-program to add the parentheses only for numbers.

Reported-by: Ingo Molnar <[email protected]>
Signed-off-by: Alexander van Heukelum <[email protected]>
Acked-by: Jan Beulich <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
  • Loading branch information
heukelum authored and Ingo Molnar committed Oct 22, 2010
1 parent 3234282 commit a22dcdb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ targets += arch/$(SRCARCH)/kernel/asm-offsets.s
# Default sed regexp - multiline due to syntax constraints
define sed-y
"/^->/{s:->#\(.*\):/* \1 */:; \
s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 (\2) /* \3 */:; \
s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 (\2) /* \3 */:; \
s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; \
s:->::; p;}"
endef

Expand Down

0 comments on commit a22dcdb

Please sign in to comment.