Skip to content

Commit

Permalink
drm/amd/amdgpu: Replace kmap() with kmap_local_page()
Browse files Browse the repository at this point in the history
kmap() is being deprecated in favor of kmap_local_page().

There are two main problems with kmap(): (1) It comes with an overhead as
mapping space is restricted and protected by a global lock for
synchronization and (2) it also requires global TLB invalidation when the
kmap’s pool wraps and it might block when the mapping space is fully
utilized until a slot becomes available.

With kmap_local_page() the mappings are per thread, CPU local, can take
page faults, and can be called from any context (including interrupts).
It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore,
the tasks can be preempted and, when they are scheduled to run again, the
kernel virtual addresses are restored and are still valid.

Since its use in amdgpu/amdgpu_ttm.c is safe, it should be preferred.

Therefore, replace kmap() with kmap_local_page() in amdgpu/amdgpu_ttm.c.

Suggested-by: Ira Weiny <[email protected]>
Acked-by: Christian König <[email protected]>
Signed-off-by: Fabio M. De Francesco <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
  • Loading branch information
xp4ns3 authored and alexdeucher committed Oct 17, 2022
1 parent cdabbde commit a2c5542
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
Original file line number Diff line number Diff line change
Expand Up @@ -2292,9 +2292,9 @@ static ssize_t amdgpu_iomem_read(struct file *f, char __user *buf,
if (p->mapping != adev->mman.bdev.dev_mapping)
return -EPERM;

ptr = kmap(p);
ptr = kmap_local_page(p);
r = copy_to_user(buf, ptr + off, bytes);
kunmap(p);
kunmap_local(ptr);
if (r)
return -EFAULT;

Expand Down Expand Up @@ -2343,9 +2343,9 @@ static ssize_t amdgpu_iomem_write(struct file *f, const char __user *buf,
if (p->mapping != adev->mman.bdev.dev_mapping)
return -EPERM;

ptr = kmap(p);
ptr = kmap_local_page(p);
r = copy_from_user(ptr + off, buf, bytes);
kunmap(p);
kunmap_local(ptr);
if (r)
return -EFAULT;

Expand Down

0 comments on commit a2c5542

Please sign in to comment.