Skip to content

Commit

Permalink
kcsan: Remove CONFIG_KCSAN_DEBUG
Browse files Browse the repository at this point in the history
By this point CONFIG_KCSAN_DEBUG is pretty useless, as the system just
isn't usable with it due to spamming console (I imagine a randconfig
test robot will run into this sooner or later). Remove it.

Back in 2019 I used it occasionally to record traces of watchpoints and
verify the encoding is correct, but these days we have proper tests. If
something similar is needed in future, just add it back ad-hoc.

Signed-off-by: Marco Elver <[email protected]>
Acked-by: Mark Rutland <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
  • Loading branch information
melver authored and paulmckrcu committed Jul 20, 2021
1 parent eb32f9f commit a7a7369
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
9 changes: 0 additions & 9 deletions kernel/kcsan/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -479,15 +479,6 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type)
break; /* ignore; we do not diff the values */
}

if (IS_ENABLED(CONFIG_KCSAN_DEBUG)) {
kcsan_disable_current();
pr_err("watching %s, size: %zu, addr: %px [slot: %d, encoded: %lx]\n",
is_write ? "write" : "read", size, ptr,
watchpoint_slot((unsigned long)ptr),
encode_watchpoint((unsigned long)ptr, size, is_write));
kcsan_enable_current();
}

/*
* Delay this thread, to increase probability of observing a racy
* conflicting access.
Expand Down
3 changes: 0 additions & 3 deletions lib/Kconfig.kcsan
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ config KCSAN_VERBOSE
generated from any one of them, system stability may suffer due to
deadlocks or recursion. If in doubt, say N.

config KCSAN_DEBUG
bool "Debugging of KCSAN internals"

config KCSAN_SELFTEST
bool "Perform short selftests on boot"
default y
Expand Down

0 comments on commit a7a7369

Please sign in to comment.