Skip to content

Commit

Permalink
block: kyber: fix domain token leak during requeue
Browse files Browse the repository at this point in the history
When requeuing request, the domain token should have been freed
before re-inserting the request to io scheduler. Otherwise, the
assigned domain token will be leaked, and IO hang can be caused.

Cc: Paolo Valente <[email protected]>
Cc: Omar Sandoval <[email protected]>
Cc: [email protected]
Reviewed-by: Bart Van Assche <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Ming Lei authored and axboe committed Feb 24, 2018
1 parent 105976f commit ba989a0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions block/kyber-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -833,6 +833,7 @@ static struct elevator_type kyber_sched = {
.limit_depth = kyber_limit_depth,
.prepare_request = kyber_prepare_request,
.finish_request = kyber_finish_request,
.requeue_request = kyber_finish_request,
.completed_request = kyber_completed_request,
.dispatch_request = kyber_dispatch_request,
.has_work = kyber_has_work,
Expand Down

0 comments on commit ba989a0

Please sign in to comment.