Skip to content

Commit

Permalink
drm/panel: ld9040: Register a backlight device
Browse files Browse the repository at this point in the history
Register a backlight device to be able to switch between all the gamma
levels.

v2: Remove .get_brightness() callback, use bl_get_data() and
    backlight_get_brightness()

Signed-off-by: Paul Cercueil <[email protected]>
Reviewed-by: Sam Ravnborg <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
pcercuei committed Jul 14, 2023
1 parent 50f600f commit c2268da
Showing 1 changed file with 30 additions and 1 deletion.
31 changes: 30 additions & 1 deletion drivers/gpu/drm/panel/panel-samsung-ld9040.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* Andrzej Hajda <[email protected]>
*/

#include <linux/backlight.h>
#include <linux/delay.h>
#include <linux/gpio/consumer.h>
#include <linux/module.h>
Expand Down Expand Up @@ -310,8 +311,30 @@ static int ld9040_parse_dt(struct ld9040 *ctx)
return 0;
}

static int ld9040_bl_update_status(struct backlight_device *dev)
{
struct ld9040 *ctx = bl_get_data(dev);

ctx->brightness = backlight_get_brightness(dev);
ld9040_brightness_set(ctx);

return 0;
}

static const struct backlight_ops ld9040_bl_ops = {
.update_status = ld9040_bl_update_status,
};

static const struct backlight_properties ld9040_bl_props = {
.type = BACKLIGHT_RAW,
.scale = BACKLIGHT_SCALE_NON_LINEAR,
.max_brightness = ARRAY_SIZE(ld9040_gammas) - 1,
.brightness = ARRAY_SIZE(ld9040_gammas) - 1,
};

static int ld9040_probe(struct spi_device *spi)
{
struct backlight_device *bldev;
struct device *dev = &spi->dev;
struct ld9040 *ctx;
int ret;
Expand All @@ -323,7 +346,7 @@ static int ld9040_probe(struct spi_device *spi)
spi_set_drvdata(spi, ctx);

ctx->dev = dev;
ctx->brightness = ARRAY_SIZE(ld9040_gammas) - 1;
ctx->brightness = ld9040_bl_props.brightness;

ret = ld9040_parse_dt(ctx);
if (ret < 0)
Expand Down Expand Up @@ -353,6 +376,12 @@ static int ld9040_probe(struct spi_device *spi)
drm_panel_init(&ctx->panel, dev, &ld9040_drm_funcs,
DRM_MODE_CONNECTOR_DPI);

bldev = devm_backlight_device_register(dev, dev_name(dev), dev,
ctx, &ld9040_bl_ops,
&ld9040_bl_props);
if (IS_ERR(bldev))
return PTR_ERR(bldev);

drm_panel_add(&ctx->panel);

return 0;
Expand Down

0 comments on commit c2268da

Please sign in to comment.