Skip to content

Commit

Permalink
block: remove an incorrect check from blk_rq_append_bio
Browse files Browse the repository at this point in the history
blk_rq_append_bio is also used for the copy case, not just the map case,
so tis debug check is not correct.

Fixes: 393bb12 ("block: stop calling blk_queue_bounce for passthrough requests")
Reported-by: Guenter Roeck <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
Tested-by: Guenter Roeck <[email protected]>
Reviewed-by: Himanshu Madhani <[email protected]>
Reviewed-by: Chaitanya Kulkarni <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Christoph Hellwig authored and axboe committed Apr 12, 2021
1 parent d173b65 commit cbb749c
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions block/blk-map.c
Original file line number Diff line number Diff line change
Expand Up @@ -485,9 +485,6 @@ int blk_rq_append_bio(struct request *rq, struct bio *bio)
struct bio_vec bv;
unsigned int nr_segs = 0;

if (WARN_ON_ONCE(rq->q->limits.bounce != BLK_BOUNCE_NONE))
return -EINVAL;

bio_for_each_bvec(bv, bio, iter)
nr_segs++;

Expand Down

0 comments on commit cbb749c

Please sign in to comment.